Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNV-40335: fix search preferences and isntancetype by label #1939

Conversation

upalatucci
Copy link
Member

馃摑 Description

When clicking on labels in the resource details page, the page gets redirected to the search page with the resource kind and label selected. Just like in photo. In those cases, console load the resource list page declared in the console-extension file with some props.

  • make sure to hide tabs (Cluster / User ) in the preference and instancetype page and just show the list when the list is rendered in the search page (using the useIsSearchPage hook)
  • make sure the component use the props passed from search like fieldSelector, selector and nameFilter to filter the resources in the list

We should do the same with the other resources that we support

Screenshot from 2024-05-13 14-45-19
Screenshot from 2024-05-13 14-45-12

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented May 13, 2024

@upalatucci: This pull request references CNV-40335 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

馃摑 Description

When clicking on labels in the resource details page, the page gets redirected to the search page with the resource kind and label selected. Just like in photo. In those cases, console load the resource list page declared in the console-extension file with some props.

  • make sure to hide tabs (Cluster / User ) in the preference and instancetype page and just show the list when the list is rendered in the search page (using the useIsSearchPage hook)
  • make sure the component use the props passed from search like fieldSelector, selector and nameFilter to filter the resources in the list

We should do the same with the other resources that we support

Screenshot from 2024-05-13 14-45-19
Screenshot from 2024-05-13 14-45-12

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot added the approved This issue is something we want to fix label May 13, 2024
@metalice
Copy link
Member

lets talk about it, there is a significant design change here

@metalice metalice requested review from metalice and removed request for yaacov May 15, 2024 05:21
@upalatucci upalatucci force-pushed the fix-instancetype-preferences-search branch from a56d6da to 93e5ef1 Compare May 15, 2024 13:40
@metalice
Copy link
Member

/lgtm

@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label May 15, 2024
Copy link
Contributor

openshift-ci bot commented May 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: metalice, upalatucci

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [metalice,upalatucci]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 8ccc03e into kubevirt-ui:main May 15, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This issue is something we want to fix jira/valid-reference lgtm Passed code review, ready for merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants