Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

CNV-38284: UI settings should not be stored in default namespace #1893

Closed

Conversation

avivtur
Copy link
Member

@avivtur avivtur commented Apr 21, 2024

馃摑 Description

We are moving the UI settings ConfigMap to openshift-cnv namespace.
If an existing CM is on the default namespace, we ignore it and create a new one to openshift-cnv namespace.

馃帴 Demo

After:
user-settings-cm-openshift-cnv

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Apr 21, 2024

@avivtur: This pull request references CNV-38284 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.16.0" version, but no target version was set.

In response to this:

馃摑 Description

We are moving the UI settings ConfigMap to openshift-cnv namespace.
If an existing CM is on the default namespace, we ignore it and create a new one to openshift-cnv namespace.

馃帴 Demo

After:
user-settings-cm-openshift-cnv

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@openshift-ci openshift-ci bot requested review from hstastna and yaacov April 21, 2024 14:47
@openshift-ci openshift-ci bot added the approved This issue is something we want to fix label Apr 21, 2024
@hstastna
Copy link
Member

/retest

2 similar comments
@hstastna
Copy link
Member

/retest

@hstastna
Copy link
Member

/retest

@openshift-ci openshift-ci bot added the lgtm Passed code review, ready for merge label Apr 22, 2024
Copy link
Contributor

openshift-ci bot commented Apr 22, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: avivtur, upalatucci

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@upalatucci
Copy link
Member

/retest

3 similar comments
@upalatucci
Copy link
Member

/retest

@hstastna
Copy link
Member

/retest

@hstastna
Copy link
Member

/retest

@avivtur
Copy link
Member Author

avivtur commented Apr 25, 2024

/hold
kubevirt-e2e is failing

@gouyang
Copy link
Member

gouyang commented May 6, 2024

/retest

@metalice
Copy link
Member

@avivtur any update here?

@avivtur
Copy link
Member Author

avivtur commented May 29, 2024

/retest

Signed-off-by: Aviv Turgeman <aturgema@redhat.com>
@avivtur avivtur force-pushed the ui-settings-openshift-cnv-ns branch from 95f74e9 to 14a71e0 Compare May 29, 2024 10:05
@openshift-ci openshift-ci bot removed the lgtm Passed code review, ready for merge label May 29, 2024
Copy link
Contributor

openshift-ci bot commented May 29, 2024

New changes are detected. LGTM label has been removed.

@avivtur
Copy link
Member Author

avivtur commented May 29, 2024

/retest

Signed-off-by: Aviv Turgeman <aturgema@redhat.com>
Copy link
Contributor

openshift-ci bot commented May 29, 2024

@avivtur: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/kubevirt-e2e-aws 8a2bf8f link true /test kubevirt-e2e-aws

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@avivtur avivtur closed this May 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved This issue is something we want to fix do-not-merge/hold jira/valid-reference
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants