This repository has been archived by the owner on Jan 12, 2023. It is now read-only.
fix(styles): turn off css optimizer #646
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Deployed Preview: http://konveyor-forklift-ui-pr-646-preview.surge.sh ✨ Compare with current main branch: http://konveyor-forklift-ui-preview.surge.sh |
mturley
approved these changes
Jun 14, 2021
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes
optimize-css-assets-webpack-pluginin favor ofcss-minimizer-webpack-pluginwhich works well with webpack5. It was the css optimizer that caused some of the select menu styles to break after a recent upgrade. See this thread for discussion.Also, I fixed an issue I created when removing the unnecessary div around some of the create buttons. I see now those divs were necessary previously because you can't hang tooltips off of disabled buttons. Luckily, we already solved this case in upstream PF by allowing for aria-disabled buttons which can act as a tooltip host.
Should help close #645 and #639