Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable language support for Korean #4271

Conversation

jihoon-seo
Copy link
Contributor

What type of PR is this?

/kind feature

What this PR does / why we need it:

This PR enables language support for Korean.
(FYI: Korean-localized string files already exist in locales/ko)

Which issue(s) this PR fixes:

Fixes #4269

Special notes for reviewers:

Does this PR introduced a user-facing change?

None

Additional documentation, usage docs, etc.:


Signed-off-by: Jihoon Seo <jihoon.seo@etri.re.kr>
@ks-ci-bot ks-ci-bot added release-note-none kind/feature Categorizes issue or PR as related to a new feature. needs-ok-to-test labels Apr 11, 2024
@ks-ci-bot
Copy link
Collaborator

Hi @jihoon-seo. Thanks for your PR.

I'm waiting for a kubesphere member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@ks-ci-bot ks-ci-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 11, 2024
@donniean
Copy link

/approve

/lgtm

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label May 17, 2024
@ks-ci-bot
Copy link
Collaborator

LGTM label has been added.

Git tree hash: c51615ae230b2805b9c4de25cecc352bed8c7070

@donniean donniean added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 17, 2024
@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: donniean, jihoon-seo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot merged commit 20b2784 into kubesphere:master May 17, 2024
6 checks passed
@jihoon-seo jihoon-seo deleted the 240411_Enable_language_support_for_Korean branch May 17, 2024 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. kind/feature Categorizes issue or PR as related to a new feature. lgtm Indicates that a PR is ready to be merged. needs-ok-to-test release-note-none size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Language Support for Korean
3 participants