Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Container log line too long #2623

Closed
wants to merge 1 commit into from
Closed

fix: Container log line too long #2623

wants to merge 1 commit into from

Conversation

weili520
Copy link
Collaborator

@weili520 weili520 commented Nov 19, 2021 •
edited

Signed-off-by: TheYoungManLi 33231138+weili520@users.noreply.github.com

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes ##1257

Special notes for reviewers:

截屏2021-11-19 14 58 29

Does this PR introduced a user-facing change?

Container log line too long when viewing container log deatil

Additional documentation, usage docs, etc.:

@weili520
fix: Container log line too long
c02db1f 
Signed-off-by: TheYoungManLi <33231138+weili520@users.noreply.github.com>
@ks-ci-bot ks-ci-bot added release-note-none kind/bug Categorizes issue or PR as related to a bug. labels Nov 19, 2021
@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: weili520
To complete the pull request process, please assign leoendless after the PR has been reviewed.
You can assign the PR to them by writing /assign @leoendless in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Nov 19, 2021
JohnNiang
JohnNiang reviewed Nov 19, 2021
View reviewed changes
Copy link
Member

@JohnNiang JohnNiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @weili520 , please read the description of #1257 (comment) again, he/she told us the tail log didn't show if we switched to real-time log display.

src/components/Cards/ContainerLog/index.scss
@@ -53,7 +53,7 @@
color: #b7c4d1;
font-weight: 600;
line-height: 20px;
white-space: pre;
white-space: pre-wrap;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

IMO, while-space: pre works well. It's not recommended to wrapping the log, which would let the log display messy.

@weili520
Copy link
Collaborator Author

/hold

@zryfish
Copy link
Member

zryfish commented Dec 1, 2021

@weili520 Any update on this PR?

@weili520 weili520 closed this Dec 1, 2021
@weili520 weili520 deleted the container_log_space branch April 22, 2022 02:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JohnNiang JohnNiang JohnNiang left review comments

Assignees
No one assigned
Labels
do-not-merge/hold kind/bug Categorizes issue or PR as related to a bug. release-note size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@weili520 @ks-ci-bot @zryfish @JohnNiang