Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Container logs do not display full Spaces. #2103

Merged
merged 1 commit into from Jul 13, 2021

Conversation

ruibaby
Copy link
Contributor

@ruibaby ruibaby commented Jul 12, 2021

What type of PR is this?

/kind bug

What this PR does / why we need it:

Display log contents correctly.

Which issue(s) this PR fixes:

Fixes #

Special notes for reviewers:

Additional documentation, usage docs, etc.:


before After
Snipaste_2021-07-12_23-41-44 Snipaste_2021-07-12_23-41-26
Snipaste_2021-07-12_23-46-58 Snipaste_2021-07-12_23-46-45

@ks-ci-bot ks-ci-bot added kind/bug Categorizes issue or PR as related to a bug. dco-signoff: no size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 12, 2021
@JohnNiang
Copy link
Member

Hi @ruibaby , please sign off your commit.

Signed-off-by: Ryan Wang <i@ryanc.cc>
@JohnNiang
Copy link
Member

Thank @ruibaby for first contribution to KubeSphere.

/assign @harrisonliu5

@harrisonliu5
Copy link
Collaborator

/assign @xuliwenwenwen

@xuliwenwenwen
Copy link
Contributor

/lgtm

@ks-ci-bot ks-ci-bot added the lgtm Indicates that a PR is ready to be merged. label Jul 13, 2021
@harrisonliu5
Copy link
Collaborator

Thank @ruibaby for your contribution to KubeSphere

/approve

@ks-ci-bot
Copy link
Collaborator

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: harrisonliu5, ruibaby

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ks-ci-bot ks-ci-bot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 13, 2021
@ks-ci-bot ks-ci-bot merged commit 501cef4 into kubesphere:master Jul 13, 2021
@ruibaby ruibaby deleted the fix/container-log-white-space branch July 13, 2021 07:45
@harrisonliu5
Copy link
Collaborator

fix: ##1257

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. dco-signoff: yes kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants