Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Socket Mode documentation is added #147

Merged
merged 4 commits into from
Sep 30, 2022
Merged

Socket Mode documentation is added #147

merged 4 commits into from
Sep 30, 2022

Conversation

huseyinbabal
Copy link
Contributor

@huseyinbabal huseyinbabal commented Sep 23, 2022 •
edited

Description

Changes proposed in this pull request:

  • Added Slack documentation for Socket Mode

Testing Locally

Proof

Screen Shot 2022-09-23 at 16 41 39

Related issue(s)

Documentation for #631

@huseyinbabal huseyinbabal marked this pull request as ready for review September 23, 2022 13:48
@huseyinbabal huseyinbabal requested review from pkosiec and removed request for a team September 23, 2022 13:48
@pkosiec pkosiec added the enhancement New feature or request label Sep 30, 2022
pkosiec
pkosiec approved these changes Sep 30, 2022
View reviewed changes
Copy link
Member

@pkosiec pkosiec left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To speed up this, as agreed, I pushed suggested changes (commit). Feel free to revert the ones you don't like 🙂
I went through the all updated docs and it works fine, so LGTM 🚀

@huseyinbabal
Copy link
Contributor Author

Checked locally via npm run start and seems ok, thanks 🙏

@huseyinbabal huseyinbabal merged commit 3e4671a into kubeshop:main Sep 30, 2022
@huseyinbabal huseyinbabal deleted the slack-socket-mode branch September 30, 2022 11:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pkosiec pkosiec pkosiec approved these changes

@PrasadG193 PrasadG193 Awaiting requested review from PrasadG193 PrasadG193 is a code owner

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@huseyinbabal @pkosiec