Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added Azure repo scanning support #999

Closed
wants to merge 1 commit into from

Conversation

anubhav06
Copy link
Contributor

Signed-off-by: Anubhav Gupta mail.anubhav06@gmail.com

Describe your changes

Added support for scanning remote repositories hosted on Azure
This PR is linked with "added Azure API support #6", and that needs to be merged before, in order for this to work.

ABOUT THE CHANGES:
Updated the version of go-git, as the present version does not support cloning of Azure DevOps repos.
The new version of go-git has a temporary solution for cloning of Azure repos, as the Azure support is not fully implemented yet.

Thus, we have to provide the AZURE_TOKEN when scanning even public repos.

Screenshots - If Any (Optional)

When AZURE_TOKEN is provided:
2

When AZURE_TOKEN is not provided:
3

This PR fixes:

Checklist before requesting a review

  • My code follows the style guidelines of this project
  • I have commented on my code, particularly in hard-to-understand areas
  • I have performed a self-review of my code
  • If it is a core feature, I have added thorough tests.
  • New and existing unit tests pass locally with my changes

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi! Welcome to Kubescape. Thank you for taking the time and contributing to the open source community

We will try to review as soon as possible!

@matthyx
Copy link
Contributor

matthyx commented Jan 6, 2023

@anubhav06 as we have merged your PR into go-git-url, can you bump it in your go.mod?
also it seems there is a v5.5.2 version of go-git: https://pkg.go.dev/github.com/go-git/go-git/v5

@matthyx
Copy link
Contributor

matthyx commented Jan 6, 2023

@anubhav06 can you also rebase with latest dev branch and resolve conflicts before I merge?

@matthyx
Copy link
Contributor

matthyx commented Jan 6, 2023

For fixing the merge conflicts, should I pull from the master or dev branch ?

dev

@matthyx
Copy link
Contributor

matthyx commented Jan 6, 2023

can you squash also into 1 commit, pls?

@anubhav06
Copy link
Contributor Author

Yes sure, I'm really sorry for adding multiple commits. Fixing this in a few minutes

@matthyx
Copy link
Contributor

matthyx commented Jan 6, 2023

Yes sure, I'm really sorry for adding multiple commits. Fixing this in a few minutes

no worries :)

Signed-off-by: Anubhav Gupta <mail.anubhav06@gmail.com>
@anubhav06
Copy link
Contributor Author

Apologies, This is taking some time. I'll create a new PR for this by EOD, if it's ok.

@matthyx
Copy link
Contributor

matthyx commented Jan 6, 2023

Apologies, This is taking some time. I'll create a new PR for this by EOD, if it's ok.

You have issues rebasing and solving conflicts? No problem take your time and I'll merge it on Monday.
You can check this doc if that helps: https://docs.github.com/en/get-started/using-git/resolving-merge-conflicts-after-a-git-rebase
Good luck !

@anubhav06
Copy link
Contributor Author

Opened #1012 instead of this

@anubhav06 anubhav06 closed this Jan 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants