Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Turn interactive tutorials into custom 404 pages #46323

Merged
merged 1 commit into from May 13, 2024
Merged

Turn interactive tutorials into custom 404 pages #46323

merged 1 commit into from May 13, 2024

Conversation

sftim
Copy link
Contributor

@sftim sftim commented May 11, 2024 •
edited

Katacoda has shut down for good, and we have not added a local / in-project alternative playground in the time since. Serving a 404 helps cement that these pages are no longer part of the site.

Current vs Preview

You can see that Netlify now serves a 404 response:

$ curl -I https://deploy-preview-46323--kubernetes-io-main-staging.netlify.app/docs/tutorials/kubernetes-basics/create-cluster/cluster-interactive/
HTTP/2 404
accept-ranges: bytes
age: 5
cache-control: public,max-age=0,must-revalidate
cache-status: "Netlify Edge"; hit
content-type: text/html; charset=UTF-8
date: Sat, 11 May 2024 18:09:42 GMT
etag: "36ab67890e83ba39dc167967790a3a18-ssl"
server: Netlify
strict-transport-security: max-age=31536000; includeSubDomains; preload
x-nf-request-id: 01HXMDHCHAWGSRN9EWJ6XEM9PC
x-robots-tag: noindex
content-length: 463824

/area web-development

@sftim
Turn interactive tutorials into custom 404 pages
1bd0de1 
Katacoda has shut down for good, and we have not added a local /
in-project alternative playground in the time since. Serving a 404 helps
cement that these pages are no longer part of the site.
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. area/web-development Issues or PRs related to the kubernetes.io's infrastructure, design, or build processes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language labels May 11, 2024
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels May 11, 2024
@netlify Netlify
Copy link

netlify bot commented May 11, 2024

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 1bd0de1
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/663fb38902266a0008b26783
😎 Deploy Preview https://deploy-preview-46323--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sftim sftim marked this pull request as ready for review May 11, 2024 18:26
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label May 11, 2024
@stmcginnis
Copy link
Contributor

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 11, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: f2d269e7ea1b3afad7b74692ffb2c689d47e90a2

Arhell
Arhell reviewed May 12, 2024
View reviewed changes
Copy link
Member

@Arhell Arhell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

divya-mohan0209
divya-mohan0209 reviewed May 13, 2024
View reviewed changes
Copy link
Contributor

@divya-mohan0209 divya-mohan0209 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: divya-mohan0209

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 13, 2024
@k8s-ci-robot k8s-ci-robot merged commit 46fb32a into kubernetes:main May 13, 2024
6 checks passed
@sftim sftim mentioned this pull request May 22, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@divya-mohan0209 divya-mohan0209 divya-mohan0209 left review comments

@Arhell Arhell Arhell left review comments

@reylejano reylejano Awaiting requested review from reylejano

@dipesh-rawat dipesh-rawat Awaiting requested review from dipesh-rawat

Assignees

@stmcginnis stmcginnis

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/web-development Issues or PRs related to the kubernetes.io's infrastructure, design, or build processes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@sftim @stmcginnis @k8s-ci-robot @divya-mohan0209 @Arhell