Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[id] Fix incorrect relative URLs #46308

Merged
merged 2 commits into from May 13, 2024
Merged

[id] Fix incorrect relative URLs #46308

merged 2 commits into from May 13, 2024

Conversation

shurup
Copy link
Member

@shurup shurup commented May 10, 2024

I found two pages where relative URLs (../../<etc>) were used with no visible reason. This PR fixes them.

@shurup
Fix incorrect relative URLs
8afbe00 
Signed-off-by: Dmitry Shurupov <dmitry.shurupov@palark.com>
@shurup shurup added the language/id Issues or PRs related to Indonesian language label May 10, 2024
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/localization General issues or PRs related to localization labels May 10, 2024
@netlify Netlify
Copy link

netlify bot commented May 10, 2024 •
edited

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit a023346
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/663e291f1704d500084fa65a
😎 Deploy Preview https://deploy-preview-46308--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@shurup @dipesh-rawat
Update content/id/docs/concepts/architecture/controller.md
a023346 
Co-authored-by: Dipesh Rawat <rawat.dipesh@gmail.com>
dipesh-rawat
dipesh-rawat reviewed May 10, 2024
View reviewed changes
Copy link
Member

@dipesh-rawat dipesh-rawat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM makes sense to use the language specific links.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 10, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: e52f830ef131856ade9a35bb707dec4e99da4ae5

@dipesh-rawat
Copy link
Member

/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added the tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. label May 10, 2024
ricardoamaro
ricardoamaro approved these changes May 13, 2024
View reviewed changes
Copy link
Contributor

@ricardoamaro ricardoamaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have reviewed this PR, and it does fix the issue of both links
/lgtm

@k8s-ci-robot
Copy link
Contributor

@ricardoamaro: changing LGTM is restricted to collaborators

In response to this:

I have reviewed this PR, and it does fix the issue of both links
/lgtm

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

habibrosyad
habibrosyad approved these changes May 13, 2024
View reviewed changes
Copy link
Member

@habibrosyad habibrosyad left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: habibrosyad, ricardoamaro

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 13, 2024
@k8s-ci-robot k8s-ci-robot merged commit 33d2b99 into kubernetes:main May 13, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dipesh-rawat dipesh-rawat dipesh-rawat left review comments

@ricardoamaro ricardoamaro ricardoamaro approved these changes

@habibrosyad habibrosyad habibrosyad approved these changes

@girikuncoro girikuncoro Awaiting requested review from girikuncoro

Assignees

@habibrosyad habibrosyad

@dipesh-rawat dipesh-rawat

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/localization General issues or PRs related to localization cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/id Issues or PRs related to Indonesian language lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@shurup @k8s-ci-robot @dipesh-rawat @ricardoamaro @habibrosyad