Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

update rbd volume #46304

Merged
merged 1 commit into from May 10, 2024
Merged

update rbd volume #46304

merged 1 commit into from May 10, 2024

Conversation

carlory
Copy link
Member

@carlory carlory commented May 10, 2024 •
edited

@k8s-ci-robot k8s-ci-robot added this to the 1.31 milestone May 10, 2024
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 10, 2024
@netlify Netlify
Copy link

netlify bot commented May 10, 2024 •
edited

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit 292b0bf
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/663ddfa8684ea000088962d2

@netlify Netlify
Copy link

netlify bot commented May 10, 2024 •
edited

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 292b0bf
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/663ddfa851da0f0008a01141
😎 Deploy Preview https://deploy-preview-46304--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@carlory
Copy link
Member Author

carlory commented May 10, 2024

/cc @jsafrane @humblec

for tech review

@sftim
Copy link
Contributor

sftim commented May 10, 2024

/sig storage

@k8s-ci-robot k8s-ci-robot added the sig/storage Categorizes an issue or PR as relevant to SIG Storage. label May 10, 2024
sftim
sftim previously requested changes May 10, 2024
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. This needs a couple of tweaks.

content/en/docs/concepts/storage/persistent-volumes.md Outdated
@@ -530,7 +530,7 @@ please install corresponding CSI drivers.
* [`portworxVolume`](/docs/concepts/storage/volumes/#portworxvolume) - Portworx volume
(**deprecated** starting v1.25)
* [`rbd`](/docs/concepts/storage/volumes/#rbd) - Rados Block Device (RBD) volume
(**deprecated** starting v1.28, no migration plan, support will be removed in a future release)
(**deprecated** starting v1.28, no migration plan, support was removed in v1.31)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This needs to move to come after the text:

Older versions of Kubernetes also supported the following in-tree PersistentVolume types:

content/en/docs/concepts/storage/volumes.md Outdated
contents of an `rbd` volume are preserved and the volume is unmounted. This
means that a RBD volume can be pre-populated with data, and that data can be
shared between pods.
### rbd (removed)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
### rbd (removed)
### rbd (removed) {#rbd}

@carlory
Copy link
Member Author

carlory commented May 10, 2024

@sftim thanks for your review. updated.

@jsafrane
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 10, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 0b3dea24d5f7509f18bdb2017d75f33f8ad13341

sftim
sftim reviewed May 10, 2024
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one more thing, I think.

content/en/docs/concepts/storage/persistent-volumes.md
Comment on lines 545 to +548
* `storageos` - StorageOS volume.
(**not available** starting v1.25)
* [`rbd`](/docs/concepts/storage/volumes/#rbd) - Rados Block Device (RBD) volume
(**not available** starting v1.31)
Copy link
Contributor

@sftim sftim May 10, 2024 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alphabetical order please

Actually, this should be in alphabetical order, but already isn't. Can fix that in another PR.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sftim thanks. I will update it after kubernetes/kubernetes#124544 is merged.

@sftim sftim dismissed their stale review May 10, 2024 13:11

Feedback was addressed

sftim
sftim reviewed May 10, 2024
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 10, 2024
@k8s-ci-robot k8s-ci-robot merged commit fd842ff into kubernetes:dev-1.31 May 10, 2024
6 checks passed
@humblec
Copy link
Contributor

humblec commented May 13, 2024

/lgtm . Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim left review comments

@thockin thockin Awaiting requested review from thockin

@xing-yang xing-yang Awaiting requested review from xing-yang

@humblec humblec Awaiting requested review from humblec

@jsafrane jsafrane Awaiting requested review from jsafrane

Assignees

@jsafrane jsafrane

@sftim sftim

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/storage Categorizes an issue or PR as relevant to SIG Storage. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
1.31
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@carlory @sftim @jsafrane @k8s-ci-robot @humblec