New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Note needed in "Using a Service to Expose Your App > Step 3: Deleting a service" #46292
base: main
Are you sure you want to change the base?
Note needed in "Using a Service to Expose Your App > Step 3: Deleting a service" #46292
Conversation
vishalbidwe
commented
May 9, 2024
•
edited
edited
- Added Note to clarify the service's expected results, addressing potential confusion among users till cache gets cleared.
- Closes: Note needed in "Using a Service to Expose Your App > Step 3: Deleting a service" #46105
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
Note, if you add the following line to your PR description: Closes: #46105 It will automatically link this PR to the issue so it is visible, and when this PR merges it will automatically close the issue it is addressing. |
@stmcginnis Thanks for providing input I'll add |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am putting this PR on hold since the issue submitter hasn't clarified why there is a requirement for this line.
There's already an existing comment that explicitly asks the user to confirm that the service is gone before following the next steps.
/hold