remove feature-gate CSINodeExpandSecret #46284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
cncf-cla: yes
👷 Deploy Preview for kubernetes-io-vnext-staging processing.
|
carlory
force-pushed
the
dev-1.31-ConsistentHTTPGetHandlers
branch
from
7b057c2
to
15fac06
Compare
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Pull request preview available for checkingBuilt without sensitive environment variables
To edit notification comments on pull requests, go to your Netlify site configuration. |
|
Please check if |
carlory
force-pushed
the
dev-1.31-ConsistentHTTPGetHandlers
branch
from
15fac06
to
ac5ab5f
Compare
|
thanks @tengqm updated. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: tengqm The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
sftim
reviewed
May 9, 2024
| @@ -1061,7 +1061,7 @@ persistent volume: | |||
| call to the CSI driver. In order to use the `nodeExpandSecretRef` field, your | |||
| cluster should be running Kubernetes version 1.25 or later. | |||
| * If you are running Kubernetes Version 1.25 or 1.26, you must enable | |||
There was a problem hiding this comment.
We can drop guidance aimed at people running unsupported releases, and I typically recommend that we do.
k8s-ci-robot
added
size/S
carlory
force-pushed
the
dev-1.31-ConsistentHTTPGetHandlers
branch
from
d91e223
to
72f8423
Compare
|
/lgtm |
k8s-ci-robot
added
the
lgtm
|
LGTM label has been added. Git tree hash: 5eab578aa7db5e3e7a453c48076cd42f62652ed2
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
k/k: kubernetes/kubernetes#124462
preview https://deploy-preview-46284--kubernetes-io-main-staging.netlify.app/docs/reference/command-line-tools-reference/feature-gates-removed/