Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ja] Localization of content/ja/docs/reference/glossary/cidr.md #46267

Merged
merged 3 commits into from May 15, 2024
Merged

[ja] Localization of content/ja/docs/reference/glossary/cidr.md #46267

merged 3 commits into from May 15, 2024
+17 −0

Conversation

hihumikan
Copy link
Contributor

close #45112

Change List

@k8s-ci-robot k8s-ci-robot requested a review from bells17 May 8, 2024 08:12
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/localization General issues or PRs related to localization labels May 8, 2024
@k8s-ci-robot k8s-ci-robot requested a review from t-inu May 8, 2024 08:12
@k8s-ci-robot k8s-ci-robot added language/ja Issues or PRs related to Japanese language size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels May 8, 2024
@hihumikan
Copy link
Contributor Author

/assign Okabe-Junya

@netlify Netlify
Copy link

netlify bot commented May 8, 2024 •
edited

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit c35f015
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/66449ebde18dd20008b3af44
😎 Deploy Preview https://deploy-preview-46267--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Okabe-Junya
Copy link
Member

ありがとうございます！後ほどレビューさせて頂きますね

@Okabe-Junya
Copy link
Member

Deploy preview: https://deploy-preview-46267--kubernetes-io-main-staging.netlify.app/ja/docs/reference/glossary/?all=true#term-cidr

Okabe-Junya
Okabe-Junya suggested changes May 8, 2024
View reviewed changes
Copy link
Member

@Okabe-Junya Okabe-Junya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

コントリビューションありがとうございます！2点ほどコメントさせていただいたのでご確認をお願いいたします

content/ja/docs/reference/glossary/cidr.md Outdated Show resolved Hide resolved
content/ja/docs/reference/glossary/cidr.md Show resolved Hide resolved
@Okabe-Junya
Copy link
Member

/assign nasa9084

@hihumikan
Copy link
Contributor Author

@Okabe-Junya
レビュー頂きありがとうございます！！
先ほど修正コミットしましたのでご確認お願いします！🙏

@hihumikan hihumikan requested a review from Okabe-Junya May 8, 2024 21:51
Okabe-Junya
Okabe-Junya approved these changes May 9, 2024
View reviewed changes
Copy link
Member

@Okabe-Junya Okabe-Junya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ありがとうございます！LGTMです！

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 9, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: b6d016649fe69d6a4599b8afa615bcd0b4d79f5b

@bells17
Copy link
Contributor

bells17 commented May 15, 2024

/lgtm too

@inductor
Copy link
Member

/assign @seokho-son

@inductor
Copy link
Member

/unassign @seokho-son sorry that was a mistake

@inductor
Copy link
Member

/unassign @seokho-son

@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 15, 2024
@inductor
Copy link
Member

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 15, 2024
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 5bdfb5401b65a67887eb7d65bf2ebb0b408df709

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: inductor, Okabe-Junya

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

1 similar comment
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: inductor, Okabe-Junya

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 15, 2024
@k8s-ci-robot k8s-ci-robot merged commit d4b0776 into kubernetes:main May 15, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@inductor inductor inductor left review comments

@bells17 bells17 Awaiting requested review from bells17

@t-inu t-inu Awaiting requested review from t-inu

@nasa9084 nasa9084 Awaiting requested review from nasa9084

@Okabe-Junya Okabe-Junya Awaiting requested review from Okabe-Junya

Assignees

@nasa9084 nasa9084

@inductor inductor

@Okabe-Junya Okabe-Junya

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/localization General issues or PRs related to localization cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/ja Issues or PRs related to Japanese language lgtm "Looks good to me", indicates that a PR is ready to be merged. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[ja] Translate content/en/docs/reference/glossary/cidr.md into Japanese
7 participants
@hihumikan @Okabe-Junya @k8s-ci-robot @bells17 @inductor @seokho-son @nasa9084