Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Announce v1.29 release #43939

Merged
merged 23 commits into from
Dec 13, 2023
Merged

Announce v1.29 release #43939

merged 23 commits into from
Dec 13, 2023

Conversation

krol3
Copy link
Contributor

@krol3 krol3 commented Nov 14, 2023 •
edited

🛑 DO NOT MERGE 🛑 UNTIL KUBERNETES 1.29 IS RELEASED

Release announcement blog article for 1.29

If you prefer to collaborate using hackmd, please use it and put in the comments to include it.

@krol3
feat: WIP - blog 1.29
b1f2a51 
Signed-off-by: carolina valencia <krol3@users.noreply.github.com>
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 14, 2023
@k8s-ci-robot k8s-ci-robot added the area/blog Issues or PRs related to the Kubernetes Blog subproject label Nov 14, 2023
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Nov 14, 2023
@netlify Netlify
Copy link

netlify bot commented Nov 14, 2023 •
edited

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 5288583
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/6579d74dbca518000818acbd
😎 Deploy Preview https://deploy-preview-43939--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@sftim
Copy link
Contributor

sftim commented Nov 14, 2023

/hold

Do not publish until Kubernetes v1.29 is released.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 14, 2023
sftim
sftim reviewed Nov 14, 2023
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Here's some early feedback.

content/en/blog/_posts/2023-12-05-kubernetes-1.29.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2023-12-05-kubernetes-1.29.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2023-12-05-kubernetes-1.29.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2023-12-05-kubernetes-1.29.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2023-12-05-kubernetes-1.29.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2023-12-05-kubernetes-1.29.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2023-12-05-kubernetes-1.29.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2023-12-05-kubernetes-1.29.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2023-12-05-kubernetes-1.29.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2023-12-05-kubernetes-1.29.md Outdated Show resolved Hide resolved
mickeyboxell
mickeyboxell reviewed Nov 15, 2023
View reviewed changes
Copy link
Contributor

@mickeyboxell mickeyboxell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given the doc is still in an early state, it can be useful to iterate in a hack.md file or somewhere less formal than Github to avoid tracking every addition and revision.

content/en/blog/_posts/2023-12-05-kubernetes-1.29.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2023-12-05-kubernetes-1.29.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2023-12-05-kubernetes-1.29.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2023-12-05-kubernetes-1.29.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2023-12-05-kubernetes-1.29.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2023-12-05-kubernetes-1.29.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2023-12-05-kubernetes-1.29.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2023-12-05-kubernetes-1.29.md Outdated Show resolved Hide resolved
@sftim sftim mentioned this pull request Nov 23, 2023
Merged
andrewsykim
andrewsykim reviewed Nov 24, 2023
View reviewed changes
content/en/blog/_posts/2023-12-05-kubernetes-1.29.md Outdated

### Deprecations and removals

#### Removal of in-tree integrations with cloud providers ([KEP-2395](https://kep.k8s.io/2395))
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is pretty big change, thanks for adding it to the deprecations/removal list. I'm wondering if there's more we can do to make this change stand out more since it's a breaking change for some clusters. Can we maybe add a "What's new in sig-cloud-provider?" section at the top that also highlights this? Thoughts @elmiko @sftim (continuing the discussion from #44010)

@sftim
Copy link
Contributor

sftim commented Nov 25, 2023

@krol3, are folks in release comms willing to revise this given the feedback in https://github.com/kubernetes/website/pull/43939/files#r1393368279?

@krol3
Copy link
Contributor Author

krol3 commented Nov 29, 2023

@krol3, are folks in release comms willing to revise this given the feedback in https://github.com/kubernetes/website/pull/43939/files#r1393368279?

Hi @sftim please review the new order about the major themes. Thanks :)

mickeyboxell
mickeyboxell reviewed Nov 29, 2023
View reviewed changes
Copy link
Contributor

@mickeyboxell mickeyboxell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've added a number of minor comments to be addressed.

content/en/blog/_posts/2023-12-05-kubernetes-1.29.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2023-12-05-kubernetes-1.29.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2023-12-05-kubernetes-1.29.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2023-12-05-kubernetes-1.29.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2023-12-05-kubernetes-1.29.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2023-12-05-kubernetes-1.29.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2023-12-05-kubernetes-1.29.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2023-12-05-kubernetes-1.29.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2023-12-05-kubernetes-1.29.md Outdated Show resolved Hide resolved
content/en/blog/_posts/2023-12-05-kubernetes-1.29.md Outdated Show resolved Hide resolved
@mickeyboxell
Copy link
Contributor

Given this needs to ship in a few hours, could we commit the final few suggestions and save everything else for after this is live?

@katcosgrove
Copy link
Contributor

cc @natalisucks, Mickey's comment above

@natalisucks
Copy link
Contributor

@katcosgrove @mickeyboxell I'm fine with committing directly given the timeline – please go ahead and I'll be around to approve

mickeyboxell and others added 10 commits December 13, 2023 10:02
@mickeyboxell @ritazh
Update content/en/blog/_posts/2023-12-13-kubernetes-1.29.md
483d40a 
Co-authored-by: Rita Zhang <rita.z.zhang@gmail.com>
@mickeyboxell @ritazh
Update content/en/blog/_posts/2023-12-13-kubernetes-1.29.md
10e929d 
Co-authored-by: Rita Zhang <rita.z.zhang@gmail.com>
@mickeyboxell @ritazh
Update content/en/blog/_posts/2023-12-13-kubernetes-1.29.md
0a46de0 
Co-authored-by: Rita Zhang <rita.z.zhang@gmail.com>
@mickeyboxell @ritazh
Update content/en/blog/_posts/2023-12-13-kubernetes-1.29.md
a516155 
Co-authored-by: Rita Zhang <rita.z.zhang@gmail.com>
@mickeyboxell @ritazh
Update content/en/blog/_posts/2023-12-13-kubernetes-1.29.md
cd6a6f7 
Co-authored-by: Rita Zhang <rita.z.zhang@gmail.com>
@mickeyboxell @ritazh
Update content/en/blog/_posts/2023-12-13-kubernetes-1.29.md
aa61958 
Co-authored-by: Rita Zhang <rita.z.zhang@gmail.com>
@mickeyboxell @ritazh
Update content/en/blog/_posts/2023-12-13-kubernetes-1.29.md
ce001a1 
Co-authored-by: Rita Zhang <rita.z.zhang@gmail.com>
@mickeyboxell @ritazh
Update content/en/blog/_posts/2023-12-13-kubernetes-1.29.md
47bfd98 
Co-authored-by: Rita Zhang <rita.z.zhang@gmail.com>
@mickeyboxell @ritazh
Update content/en/blog/_posts/2023-12-13-kubernetes-1.29.md
c7fd72a 
Co-authored-by: Rita Zhang <rita.z.zhang@gmail.com>
@mickeyboxell @ritazh
Update content/en/blog/_posts/2023-12-13-kubernetes-1.29.md
109291d 
Co-authored-by: Rita Zhang <rita.z.zhang@gmail.com>
@mickeyboxell mickeyboxell dismissed Priyankasaggu11929’s stale review December 13, 2023 16:13

Discussed with Priyanka on the release team call and she agreed to close this review.

@natalisucks
Copy link
Contributor

suggestions have all been applied, so in the interest of this tight timeframe for the release, this is good as is
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Dec 13, 2023
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: e830587381bf7f6754e534d37d54b9c713dc831d

@reylejano
Copy link
Member

/lgtm

@reylejano
Copy link
Member

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: reylejano, sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@katcosgrove katcosgrove merged commit 22ff0d3 into kubernetes:main Dec 13, 2023
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kcmartin kcmartin kcmartin left review comments

@mengjiao-liu mengjiao-liu mengjiao-liu left review comments

@sanposhiho sanposhiho sanposhiho left review comments

@Priyankasaggu11929 Priyankasaggu11929 Priyankasaggu11929 left review comments

@carlory carlory carlory left review comments

@sftim sftim sftim left review comments

@katcosgrove katcosgrove katcosgrove left review comments

@a-mccarthy a-mccarthy a-mccarthy left review comments

@dipesh-rawat dipesh-rawat dipesh-rawat left review comments

@elmiko elmiko elmiko left review comments

@andrewsykim andrewsykim andrewsykim left review comments

@James-Quigley James-Quigley James-Quigley left review comments

@mickeyboxell mickeyboxell mickeyboxell left review comments

@aojea aojea aojea left review comments

@humblec humblec humblec left review comments

@ritazh ritazh ritazh left review comments

@xing-yang xing-yang xing-yang left review comments

@onlydole onlydole Awaiting requested review from onlydole

@nate-double-u nate-double-u Awaiting requested review from nate-double-u

Assignees

@natalisucks natalisucks

@sftim sftim

@reylejano reylejano

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/blog Issues or PRs related to the Kubernetes Blog subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
SIG Docs Blog Project Board
Status: Published
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet