Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct the version for the introduction of StatefulSetAutoDeletePVC feature #40893

Closed
wants to merge 1 commit into from
Closed

Correct the version for the introduction of StatefulSetAutoDeletePVC feature #40893

wants to merge 1 commit into from

Conversation

Coderayush13
Copy link
Contributor

StatefulSetAutoDeletePVC 1.22 is converted to 1.23

@Coderayush13
Update feature-gates.md
aafc6d8 
StatefulSetAutoDeletePVC 1.22 is converted to 1.23
@linux-foundation-easycla
Copy link

CLA Not Signed

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign bradtopol for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot requested a review from sftim April 29, 2023 12:11
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Apr 29, 2023
@k8s-ci-robot k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Apr 29, 2023
@k8s-ci-robot
Copy link
Contributor

Welcome @Coderayush13!

It looks like this is your first PR to kubernetes/website 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/website has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Apr 29, 2023
@Coderayush13
Copy link
Contributor Author

issue #40888

@Coderayush13
Copy link
Contributor Author

please merged it

@netlify
Copy link

netlify bot commented Apr 29, 2023

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit aafc6d8
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/644d096ada20ed00088007f0
😎 Deploy Preview https://deploy-preview-40893--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

tengqm
tengqm reviewed Apr 29, 2023
View reviewed changes
content/en/docs/reference/command-line-tools-reference/feature-gates.md
@@ -201,7 +201,7 @@ For a reference to old feature gates that are removed, please refer to
| `SizeMemoryBackedVolumes` | `false` | Alpha | 1.20 | 1.21 |
| `SizeMemoryBackedVolumes` | `true` | Beta | 1.22 | |
| `StableLoadBalancerNodeGet` | `true` | Beta | 1.27 | |
| `StatefulSetAutoDeletePVC` | `false` | Alpha | 1.22 | 1.26 |
| `StatefulSetAutoDeletePVC` | `false` | Alpha | 1.23 | 1.26 |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Checking the pkg/features/kube-feature.go, it says the gate was alpha since 1.22.
Also git log shows the feature was introduced on 2021-03-03, before 1.22 is out.
Can you confirm 1.23 is the right version?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking at the implementation history in the enhancement and the subsequent PR of implementing StatefulSetAutoDeletePVC changes, it appears this change is accurate.

Reference Links

@dipesh-rawat
Copy link
Member

@Coderayush13 Thanks you for your contribution. Could you please sign the CLA before the PR can be reviewed and merged.
You can follow the steps documented here: CLA Steps

@dipesh-rawat dipesh-rawat mentioned this pull request Apr 29, 2023
Closed
@dipesh-rawat
Copy link
Member

/retitle Correct the version for the introduction of StatefulSetAutoDeletePVC feature

@k8s-ci-robot k8s-ci-robot changed the title Update feature-gates.md Correct the version for the introduction of StatefulSetAutoDeletePVC feature Apr 30, 2023
Arhell
Arhell reviewed Apr 30, 2023
View reviewed changes
Copy link
Member

@Arhell Arhell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/easycla

@Shubham82 Shubham82 mentioned this pull request May 1, 2023
Closed
@Coderayush13
Copy link
Contributor Author

hey can you please merged it I am not able to do that CLA

@dipesh-rawat
Copy link
Member

@Coderayush13 The code can't be merged without signing Contributor License Agreement (CLA).

When you click on the Details for the EasyCLA check that is failing, what do you see?

@Shubham82
Copy link
Contributor

@Coderayush13 please follow the steps mentioned under The Contributor License Agreement docs.

dipesh-rawat
dipesh-rawat reviewed May 10, 2023
View reviewed changes
Copy link
Member

@dipesh-rawat dipesh-rawat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Marking this as duplicate of PR #41059

/triage duplicate

@k8s-ci-robot k8s-ci-robot added the triage/duplicate Indicates an issue is a duplicate of other open issue. label May 10, 2023
@dipesh-rawat
Copy link
Member

Closing in favor of PR #41059 by same author.

/close

@k8s-ci-robot
Copy link
Contributor

@dipesh-rawat: Closed this PR.

In response to this:

Closing in favor of PR #41059 by same author.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tengqm tengqm tengqm left review comments

@dipesh-rawat dipesh-rawat dipesh-rawat left review comments

@Arhell Arhell Arhell left review comments

@sftim sftim Awaiting requested review from sftim

Assignees
No one assigned
Labels
cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. triage/duplicate Indicates an issue is a duplicate of other open issue.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@Coderayush13 @k8s-ci-robot @dipesh-rawat @Shubham82 @tengqm @Arhell