Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Clarify hostNetwork and address other outstanding feedback #36710

Merged
merged 1 commit into from Sep 14, 2022
Merged

Clarify hostNetwork and address other outstanding feedback #36710

merged 1 commit into from Sep 14, 2022

Conversation

ddebroy
Copy link
Member

@ddebroy ddebroy commented Sep 9, 2022 •
edited

Address outstanding feedback and clarifications from #36197 after it was merged.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Sep 9, 2022
@k8s-ci-robot k8s-ci-robot added the area/blog Issues or PRs related to the Kubernetes Blog subproject label Sep 9, 2022
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 9, 2022
@ddebroy
Clarify hostNetwork
1f30cf2 
Signed-off-by: Deep Debroy <ddebroy@gmail.com>
@netlify
Copy link

netlify bot commented Sep 9, 2022

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit af0e462
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/631b664892f7ef000876a283
😎 Deploy Preview https://deploy-preview-36710--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@netlify
Copy link

netlify bot commented Sep 9, 2022

✅ Pull request preview available for checking

Built without sensitive environment variables

Name Link
🔨 Latest commit 1f30cf2
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-main-staging/deploys/631b66de4ff27f0009113bcb
😎 Deploy Preview https://deploy-preview-36710--kubernetes-io-main-staging.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@chrismetz09
Copy link
Contributor

@ddebroy, great blog. You have aptly described a new status as part of the pod lifecycle. A casual and/or new blog reader might find the text-only presentation challenging. A simple diagram would improve reader accessibility.

You can use Mermaid to create diagrams as described in the Diagram Guide. Check out K8s system flow diagrams as examples, Mermaid sequence diagram doc or use labeled boxes with arrows. Up to you. Keep it simple.

You can address this in another PR. Tx for researching and authoring this helpful blog. Looks fine to publish.

@sftim
Copy link
Contributor

sftim commented Sep 14, 2022

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 14, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 8505452ae81f551444bdcd5e8ac5cc28531edc99

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 14, 2022
@k8s-ci-robot k8s-ci-robot merged commit f456be2 into kubernetes:main Sep 14, 2022
@windsonsea windsonsea mentioned this pull request Sep 16, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nate-double-u nate-double-u Awaiting requested review from nate-double-u

@sftim sftim Awaiting requested review from sftim

Assignees

@sftim sftim

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/blog Issues or PRs related to the Kubernetes Blog subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@ddebroy @chrismetz09 @sftim @k8s-ci-robot