Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PodHasNetwork condition blog #35645

Closed
wants to merge 1 commit into from
Closed

PodHasNetwork condition blog #35645

wants to merge 1 commit into from

Conversation

ddebroy
Copy link
Member

@ddebroy ddebroy commented Aug 2, 2022

Placeholder for PodHasNetwork condition blog [https://github.com/kubernetes/enhancements/issues/3085]

@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Aug 2, 2022
@netlify
Copy link

netlify bot commented Aug 2, 2022 •
edited

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit 72833c6
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/6304e9194b4bbd00082dfa74

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Aug 2, 2022
@k8s-ci-robot k8s-ci-robot added area/blog Issues or PRs related to the Kubernetes Blog subproject language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels Aug 2, 2022
@reylejano reylejano added this to Planned in Blog articles Aug 3, 2022
@cathchu
Copy link
Contributor

cathchu commented Aug 4, 2022

Hey there 👋 @ddebroy , 1.25 Release Docs Shadow here!

Thanks for filing this placeholder. As a reminder, final docs PRs are due August 9th. Take a look at Documenting a release for additional information for the docs requirement for the release.

Thanks again!

@katcosgrove
Copy link
Contributor

Hi from the Comms team! Just a reminder that the Ready to Review deadline for feature blogs is Tuesday, August 16. You will also be assigned a publication date post-release. Is there anything we can do to help you right now?

@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. area/release-eng Issues or PRs related to the Release Engineering subproject language/de Issues or PRs related to German language language/fr Issues or PRs related to French language language/ja Issues or PRs related to Japanese language language/ko Issues or PRs related to Korean language language/pt Issues or PRs related to Portuguese language language/zh Issues or PRs related to Chinese language sig/release Categorizes an issue or PR as relevant to SIG Release. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 16, 2022
@k8s-ci-robot k8s-ci-robot added size/L Denotes a PR that changes 100-499 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels Aug 16, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign nate-double-u for approval by writing /assign @nate-double-u in a comment. For more information see:The Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ddebroy ddebroy changed the title [WIP] Placeholder for PodHasNetwork condition blog PodHasNetwork condition blog Aug 16, 2022
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 16, 2022
@ddebroy
Copy link
Member Author

ddebroy commented Aug 16, 2022

@katcosgrove this is now ready for review.

@Sea-n
Copy link
Member

Sea-n commented Aug 17, 2022

Remove labels introduced by changing base branch.
/remove-area release-eng
/remove-language de fr ja ko pt zh

@k8s-ci-robot k8s-ci-robot removed area/release-eng Issues or PRs related to the Release Engineering subproject language/de Issues or PRs related to German language language/fr Issues or PRs related to French language language/ja Issues or PRs related to Japanese language language/ko Issues or PRs related to Korean language language/pt Issues or PRs related to Portuguese language language/zh Issues or PRs related to Chinese language labels Aug 17, 2022
@Sea-n
Copy link
Member

Sea-n commented Aug 17, 2022

/remove-sig release

@k8s-ci-robot k8s-ci-robot removed the sig/release Categorizes an issue or PR as relevant to SIG Release. label Aug 17, 2022
@ddebroy ddebroy force-pushed the podHasNetworkBlog1 branch 3 times, most recently from 684cb70 to c03eb8c Compare August 18, 2022 14:55
@katcosgrove
Copy link
Contributor

Hi from Comms! Your assigned publication date is September 14. Thank you!

@sftim sftim moved this from Planned to Requires update in Blog articles Aug 22, 2022
@sftim sftim removed this from Requires update in Blog articles Aug 22, 2022
@ddebroy
Blog post for PodHasNetwork condition
72833c6 
Signed-off-by: Deep Debroy <ddebroy@gmail.com>
@sftim sftim dismissed their stale review August 23, 2022 15:07

Review was stale

@sftim
Copy link
Contributor

sftim commented Aug 23, 2022

Oh, also: this PR should target main, and not dev-1.25.

@ddebroy ddebroy mentioned this pull request Aug 23, 2022
Merged
@ddebroy
Copy link
Member Author

ddebroy commented Aug 23, 2022 •
edited

superseded by #36197 with rebase on main per

this PR should target main, and not dev-1.25.

Thanks for pointing out the incorrect branch!

@ddebroy ddebroy closed this Aug 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Garima-Negi Garima-Negi Garima-Negi requested changes

@sftim sftim sftim left review comments

@nate-double-u nate-double-u Awaiting requested review from nate-double-u

@onlydole onlydole Awaiting requested review from onlydole

Assignees
No one assigned
Labels
area/blog Issues or PRs related to the Kubernetes Blog subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@ddebroy @cathchu @katcosgrove @k8s-ci-robot @Sea-n @sftim @Garima-Negi