Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Document the MaxUnavailableStatefulSet feature #32596

Merged
merged 1 commit into from Apr 7, 2022
Merged

Document the MaxUnavailableStatefulSet feature #32596

merged 1 commit into from Apr 7, 2022

Conversation

tengqm
Copy link
Contributor

@tengqm tengqm commented Mar 29, 2022

@k8s-ci-robot k8s-ci-robot added this to the 1.24 milestone Mar 29, 2022
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 29, 2022
@netlify
Copy link

netlify bot commented Mar 29, 2022 •
edited

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit ecf1cd1
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/624eab2538b9ce0008d6acd2

@k8s-ci-robot k8s-ci-robot added the size/S Denotes a PR that changes 10-29 lines, ignoring generated files. label Mar 29, 2022
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Mar 29, 2022
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Mar 29, 2022
@mehabhalodiya
Copy link
Contributor

enhancement ref: kubernetes/enhancements#961
/assign

@mehabhalodiya
Copy link
Contributor

/sig apps

@k8s-ci-robot k8s-ci-robot added the sig/apps Categorizes an issue or PR as relevant to SIG Apps. label Mar 29, 2022
@krmayankk
Copy link
Contributor

i think there is more to document here for this feature

@tengqm
Copy link
Contributor Author

tengqm commented Mar 29, 2022

i think there is more to document here for this feature

@krmayankk It would be nice if you or someone can help provide more docs on this.

@tengqm tengqm force-pushed the MaxUnavailableStatefulSet-alpha branch from a77f260 to 32e56b6 Compare March 29, 2022 10:54
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Mar 29, 2022
sftim
sftim reviewed Mar 29, 2022
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Markdown etc LGTM

@krmayankk
Copy link
Contributor

i think there is more to document here for this feature

@krmayankk It would be nice if you or someone can help provide more docs on this.

i am writing a blog on that, we can use that as reference

divya-mohan0209
divya-mohan0209 previously requested changes Mar 30, 2022
View reviewed changes
Copy link
Contributor

@divya-mohan0209 divya-mohan0209 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Grammatical nit, otherwise LGTM.

content/en/docs/reference/command-line-tools-reference/feature-gates.md Outdated Show resolved Hide resolved
@tengqm tengqm force-pushed the MaxUnavailableStatefulSet-alpha branch from 32e56b6 to ebb2e62 Compare March 30, 2022 05:35
@reylejano
Copy link
Member

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 4, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 67f4b71fea87c1e18d9de60a6cf472819b448b41

@sftim sftim dismissed divya-mohan0209’s stale review April 7, 2022 08:40

Previous review is now stale

sftim
sftim approved these changes Apr 7, 2022
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

/hold
I mentioned a nit; feel free to either tweak that or to unhold and ship the changes as-is.

content/en/docs/concepts/workloads/controllers/statefulset.md Outdated Show resolved Hide resolved
@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 7, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: sftim

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 7, 2022
@tengqm tengqm force-pushed the MaxUnavailableStatefulSet-alpha branch from ebb2e62 to ecf1cd1 Compare April 7, 2022 09:13
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 7, 2022
@tengqm
Copy link
Contributor Author

tengqm commented Apr 7, 2022

/hold cancel
Nits resolved. Need another lgtm.

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 7, 2022
@sftim
Copy link
Contributor

sftim commented Apr 7, 2022

Thanks @tengqm
/lgtm

Ship it

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 7, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: cf61c229653c0d1c576bee239bf17d5d713d4abb

@k8s-ci-robot k8s-ci-robot merged commit a0d51d6 into kubernetes:dev-1.24 Apr 7, 2022
@sftim
Copy link
Contributor

sftim commented Apr 7, 2022

(BTW changes since #32596 (comment) are trivial)

@tengqm tengqm deleted the MaxUnavailableStatefulSet-alpha branch April 13, 2022 06:11
@tengqm tengqm restored the MaxUnavailableStatefulSet-alpha branch April 13, 2022 06:11
@tengqm tengqm deleted the MaxUnavailableStatefulSet-alpha branch April 13, 2022 06:11
@krmayankk
Copy link
Contributor

I wanted to write the second blog in this series, do i need to follow a process or i can go ahead and make a PR ?

@sftim
Copy link
Contributor

sftim commented Jul 31, 2022

I wanted to write the second blog in this series, do i need to follow a process or i can go ahead and make a PR ?

This PR didn't add a blog article. Maybe ask your question in #sig-docs-blog on Slack @krmayankk, and mention the URL of the article that you see as being first in a series.

@sftim
Copy link
Contributor

sftim commented Jul 31, 2022

PS. Ideally, if you're starting a series of articles, flag that to blog editors when you're looking to publish the first article.

@soltysh soltysh mentioned this pull request May 31, 2023
Open
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sftim sftim sftim approved these changes

@divya-mohan0209 divya-mohan0209 divya-mohan0209 left review comments

@kow3ns kow3ns Awaiting requested review from kow3ns

@zacharysarah zacharysarah Awaiting requested review from zacharysarah

@mehabhalodiya mehabhalodiya Awaiting requested review from mehabhalodiya

@reylejano reylejano Awaiting requested review from reylejano

Assignees

@sftim sftim

@reylejano reylejano

@mehabhalodiya mehabhalodiya

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
1.24
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@tengqm @mehabhalodiya @krmayankk @reylejano @k8s-ci-robot @sftim @divya-mohan0209