Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NodeOutOfServiceVolumeDetach feature introduced #32595

Merged
merged 1 commit into from Mar 29, 2022
Merged

NodeOutOfServiceVolumeDetach feature introduced #32595

merged 1 commit into from Mar 29, 2022

Conversation

tengqm
Copy link
Contributor

@tengqm tengqm commented Mar 29, 2022

@k8s-ci-robot k8s-ci-robot added this to the 1.24 milestone Mar 29, 2022
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 29, 2022
@netlify
Copy link

netlify bot commented Mar 29, 2022

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit f6dbb9f
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/62425c42dda2530008935953

@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. language/en Issues or PRs related to English language labels Mar 29, 2022
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Mar 29, 2022
@tengqm tengqm mentioned this pull request Mar 29, 2022
Merged
Arhell
Arhell reviewed Mar 29, 2022
View reviewed changes
Copy link
Member

@Arhell Arhell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 29, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 3f5df473091dd1c185937affb9bb13cc5ca326c4

@reylejano
Copy link
Member

Code PR kubernetes/kubernetes#108486 has merged
Related k/website PR #32406

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: reylejano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 29, 2022
@k8s-ci-robot k8s-ci-robot merged commit b2318e3 into kubernetes:dev-1.24 Mar 29, 2022
@tengqm tengqm deleted the nodeoutofservicevolumedetach branch March 29, 2022 23:26
@SystemZ SystemZ mentioned this pull request May 4, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Arhell Arhell Arhell left review comments

@rajeshdeshpande02 rajeshdeshpande02 Awaiting requested review from rajeshdeshpande02

@zacharysarah zacharysarah Awaiting requested review from zacharysarah

Assignees

@Arhell Arhell

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
1.24
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@tengqm @k8s-ci-robot @reylejano @Arhell