Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Promote IdentifyPodOS to Beta #32481

Merged
merged 1 commit into from Mar 29, 2022
Merged

Promote IdentifyPodOS to Beta #32481

merged 1 commit into from Mar 29, 2022

Conversation

tengqm
Copy link
Contributor

@tengqm tengqm commented Mar 25, 2022 •
edited

@k8s-ci-robot k8s-ci-robot added this to the 1.24 milestone Mar 25, 2022
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Mar 25, 2022
@netlify
Copy link

netlify bot commented Mar 25, 2022

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

Name Link
🔨 Latest commit 2536593
🔍 Latest deploy log https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/623d43ccd756280009d82283

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Mar 25, 2022
@k8s-ci-robot k8s-ci-robot added the language/en Issues or PRs related to English language label Mar 25, 2022
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Mar 25, 2022
@tengqm tengqm changed the title Promote IdentifyOS to Beta Promote IdentifyPodOS to Beta Mar 25, 2022
@sftim
Copy link
Contributor

sftim commented Mar 25, 2022

/sig windows

@mehabhalodiya
Copy link
Contributor

enhancement ref: kubernetes/enhancements#2802

@mehabhalodiya
Copy link
Contributor

/assign @PI-Victor

@marosset marosset mentioned this pull request Mar 25, 2022
Closed
26 tasks
@marosset
Copy link
Contributor

enhancement ref: kubernetes/enhancements#2802

Thanks!
I updated the issue description for #2802 too

@reylejano
Copy link
Member

/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Mar 25, 2022
@marosset
Copy link
Contributor

/assign

@marosset
Copy link
Contributor

LGTM
@ravisantoshgudimetla do you want to take a look?

@mehabhalodiya
Copy link
Contributor

/sig windows

@k8s-ci-robot k8s-ci-robot added the sig/windows Categorizes an issue or PR as relevant to SIG Windows. label Mar 29, 2022
ravisantoshgudimetla
ravisantoshgudimetla approved these changes Mar 29, 2022
View reviewed changes
Copy link
Contributor

@ravisantoshgudimetla ravisantoshgudimetla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for opening the PR @tengqm

The change LGTM

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 29, 2022
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: 1efeae6a3ea8cfa80b4c342bde6fa1ba07c2ccea

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ravisantoshgudimetla, reylejano

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 9f50755 into kubernetes:dev-1.24 Mar 29, 2022
@tengqm tengqm deleted the IdentifyOS-beta branch March 29, 2022 23:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ravisantoshgudimetla ravisantoshgudimetla ravisantoshgudimetla approved these changes

@jayunit100 jayunit100 Awaiting requested review from jayunit100

@mehabhalodiya mehabhalodiya Awaiting requested review from mehabhalodiya

Assignees

@PI-Victor PI-Victor

@ravisantoshgudimetla ravisantoshgudimetla

@marosset marosset

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. sig/windows Categorizes an issue or PR as relevant to SIG Windows. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
1.24
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@tengqm @sftim @mehabhalodiya @marosset @reylejano @k8s-ci-robot @ravisantoshgudimetla @PI-Victor