Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StatefulSetAutoDelete documentation #30550

Closed
wants to merge 55 commits into from
Closed

StatefulSetAutoDelete documentation #30550

wants to merge 55 commits into from

Conversation

mattcary
Copy link
Contributor

Currently this is a placeholder PR.

KEP 1847

Implementation PR #99728

ravisantoshgudimetla and others added 20 commits August 19, 2021 16:59
Recommend using ttlSecondsAfterFinished in the job spec so that the pod deletion can be guaranteed when jobs get deleted.
Co-authored-by: Tim Bannister <tim@scalefactory.com>
In my humble view, `kubectl certificate approve my-svc.my-namespace` command may understand easily to follow up this procedure.

Update managing-tls-in-a-cluster.md

Change some text as Divya Mohan's guidance.

Update managing-tls-in-a-cluster.md

Change text as sftim's guidance.! Thank you so much!
Signed-off-by: Guangwen Feng <fenggw-fnst@cn.fujitsu.com>
Signed-off-by: cndoit18 <cndoit18@outlook.com>
Delete meaningless spaces
Add English and Chinese spaces
[zh]: Add warning about using unsupported CRON_TZ
@k8s-ci-robot k8s-ci-robot added this to the 1.23 milestone Nov 18, 2021
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. labels Nov 18, 2021
@netlify
Copy link

netlify bot commented Nov 18, 2021

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

🔨 Explore the source changes: 162d7bc

🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/619b877da0c9e50007bd4d3f

@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Nov 18, 2021
@k8s-ci-robot k8s-ci-robot added the sig/docs Categorizes an issue or PR as relevant to SIG Docs. label Nov 18, 2021
@reylejano
Copy link
Member

/assign @nate-double-u
/cc @jlbutler

k8s-ci-robot and others added 3 commits November 19, 2021 02:10
Change 'container' to 'Pod' in Jobs documentation
* [zh] Update storage-classes.md

Signed-off-by: Guangwen Feng <fenggw-fnst@cn.fujitsu.com>

* [zh] Fix an invalid link in storage-classes.md

Signed-off-by: Guangwen Feng <fenggw-fnst@cn.fujitsu.com>
@sftim
Copy link
Contributor

sftim commented Nov 19, 2021

@mattcary actually I see the problem. This PR is trying to merge main into dev-1.23. You need to merge a docs branch from your fork into dev-1.23

/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Nov 19, 2021
)

* [zh] - docs/reference/command-line-tools-reference/kube-proxy.md

* [zh] - docs/reference/command-line-tools-reference/kube-apiserver.md

* [zh] - docs/reference/command-line-tools-reference/kube-controller-manager.md

* Fix some translation errors
@k8s-ci-robot k8s-ci-robot added size/XL Denotes a PR that changes 500-999 lines, ignoring generated files. and removed size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Nov 19, 2021
aravindhp and others added 5 commits November 19, 2021 12:58
- Add missing period
- Link to projected volume permission KEP instead of PR
- Add missing PowerShell command
[zh] update pod mapping to avoid deprecation notice
…low-up

storage: Minor fixes to Windows projected volumes
@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Nov 20, 2021

CLA Not Signed

@mattcary mattcary changed the title StatefulSetAutoDelete documetation StatefulSetAutoDelete documentation Nov 22, 2021
@nate-double-u
Copy link
Contributor

@mattcary, reminder that tomorrow Nov 23rd is the deadline for 1.23 Docs Ready for Review. Please correct the branch issues that @sftim highlighted, and push your docs content for this enhancement and remove the work-in-progress label when ready for review.

We have a tight turnaround to getting docs reviewed and approved for the release, and we’re hoping to have all docs in for review by EOB tomorrow. Thank you!

@mattcary
Copy link
Contributor Author

@mattcary actually I see the problem. This PR is trying to merge main into dev-1.23. You need to merge a docs branch from your fork into dev-1.23

Ack, you're right, I'm not sure how I managed to get this sideways. Let me see if I can connect the branch from my fork to this PR.

@mattcary
Copy link
Contributor Author

Hmm, I can change the base branch, but it doesn't look like I can change the branch the PR is coming from. I'll have to recreate it.

@mattcary mattcary closed this Nov 22, 2021
@mattcary
Copy link
Contributor Author

Created #30597

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. language/en Issues or PRs related to English language language/ja Issues or PRs related to Japanese language language/zh Issues or PRs related to Chinese language sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/XL Denotes a PR that changes 500-999 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet