Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Batch update feature gates for 1.22 #28849

Merged
merged 1 commit into from Jul 27, 2021
Merged

Batch update feature gates for 1.22 #28849

merged 1 commit into from Jul 27, 2021

Conversation

tengqm
Copy link
Contributor

@tengqm tengqm commented Jul 8, 2021 •
edited

Here is a second batch for feature gate updates in 1.22.

Some of these needs more detailed documentation.

@k8s-ci-robot k8s-ci-robot added this to the 1.22 milestone Jul 8, 2021
@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 8, 2021
@netlify
Copy link

netlify bot commented Jul 8, 2021 •
edited

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

🔨 Explore the source changes: 5239adf

🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/60fa6a4bfd16b50008389a69

@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jul 8, 2021
@tengqm tengqm force-pushed the featuregate-1.22-20210708 branch from b6c6b79 to 522539b Compare July 9, 2021 02:43
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 9, 2021
@tengqm tengqm force-pushed the featuregate-1.22-20210708 branch from 522539b to 4a4f8fc Compare July 11, 2021 14:07
@tengqm
Copy link
Contributor Author

tengqm commented Jul 11, 2021

I'm happy to hold this until all other on going feature gate PRs are in for 1.22.
This PR can serve as a guard so that we don't miss any changes to the feature gates.
/hold

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 11, 2021
@tengqm
Copy link
Contributor Author

tengqm commented Jul 11, 2021

Last updated: 2021-07-11 +0800 22:16

@tengqm
Copy link
Contributor Author

tengqm commented Jul 12, 2021

The StatefulSetAutoDeletePVC one is tricky. Feature gate introduced and merged but the implementation has fallen behind schedule. Need to keep an eye on it.

@mengjiao-liu
Copy link
Member

This KubeletInUserNamespace feature gate does not seem to be added.

Adds feature gate KubeletInUserNamespace which enables support for running kubelet in a user namespace.

Ref:
kubernetes/kubernetes#92863
kubernetes/kubernetes@b16323e

@tengqm
Copy link
Contributor Author

tengqm commented Jul 15, 2021

@mengjiao-liu KubeletInUserNamespace is covered by #28827. It is skipped by this PR intentionally.

@mengjiao-liu
Copy link
Member

Well, I didn't notice the #28827 PR.

@tengqm tengqm force-pushed the featuregate-1.22-20210708 branch from 4a4f8fc to bee2491 Compare July 18, 2021 09:57
@tengqm
Copy link
Contributor Author

tengqm commented Jul 18, 2021

last update: 2021-07-18 17:58 +800

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 21, 2021
@tengqm tengqm force-pushed the featuregate-1.22-20210708 branch from bee2491 to fda406e Compare July 21, 2021 04:58
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. and removed needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. labels Jul 21, 2021
@tengqm tengqm force-pushed the featuregate-1.22-20210708 branch from fda406e to e1e87c2 Compare July 22, 2021 04:49
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Jul 22, 2021
@reylejano
Copy link
Member

/cc @PI-Victor

@tengqm
Batch update feature gates for 1.22
5239adf 
Here is a second batch for feature gate updates in 1.22.

- CPUManagerPolicyOptions    kubernetes/kubernetes#101432
- ControllerManagerLeaderMigration  kubernetes/kubernetes#103533
- DynamicKubeletConfig    kubernetes/kubernetes#102966
- EndpointSliceProxying  kubernetes/kubernetes#103451
- EndpointSliceTerminatingCondition  kubernetes/kubernetes#103596
- HugePageStorageMediumSize    kubernetes/kubernetes#99144
- JobTrackingWithFinalizers   kubernetes/kubernetes#98817
  (also tracked in kubernetes#28841, can rebase).
- ServiceInternalTrafficPolicy  kubernetes/kubernetes#103462
- WindowsEndpointSliceProxying   kubernetes/kubernetes#103451

Some of these needs more detailed documentation.
@tengqm tengqm force-pushed the featuregate-1.22-20210708 branch from e1e87c2 to 5239adf Compare July 23, 2021 07:05
@tengqm
Copy link
Contributor Author

tengqm commented Jul 23, 2021

The StatefulSetAutoDeletePVC feature failed to make into 1.22. The feature gate has been removed (see kubernetes/kubernetes#103747). MemoryQoS change has been committed in a separate PR.
Last upated: 2021-07-23 15:09 +0800

@PI-Victor
Copy link
Member

Do we want to merge this at the very end, after all PRs targeting enhancements are done?

@tengqm
Copy link
Contributor Author

tengqm commented Jul 27, 2021

@PI-Victor Since the upstream code is pretty stable now. We can merge this one. Thanks for asking.
/hold cancel

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 27, 2021
@PI-Victor
Copy link
Member

awesome, thank you for the support in getting these up-to-date!

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 27, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: PI-Victor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: fad328b39f975678136e9632a491698e35f9b699

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 27, 2021
@k8s-ci-robot k8s-ci-robot merged commit 7ae9e45 into kubernetes:dev-1.22 Jul 27, 2021
@tengqm tengqm deleted the featuregate-1.22-20210708 branch July 28, 2021 02:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bradtopol bradtopol Awaiting requested review from bradtopol

@kbhawkey kbhawkey Awaiting requested review from kbhawkey

@PI-Victor PI-Victor Awaiting requested review from PI-Victor

Assignees

@PI-Victor PI-Victor

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
1.22
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@tengqm @mengjiao-liu @reylejano @PI-Victor @k8s-ci-robot