Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add documentation about SeccompDefault feature #27957

Merged
merged 1 commit into from
Jun 28, 2021
Merged

Add documentation about SeccompDefault feature #27957

merged 1 commit into from
Jun 28, 2021

Conversation

saschagrunert
Copy link
Member

@saschagrunert saschagrunert commented May 12, 2021 •
edited

This adds a documentation section about the SeccompDefault feature
gate for the kubelet. Beside that, the feature gate has been added to
the list of features, too.

Refers to kubernetes/enhancements#2413

Preview lazy link:
https://deploy-preview-27957--kubernetes-io-vnext-staging.netlify.app/docs/tutorials/clusters/seccomp

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 12, 2021
@saschagrunert saschagrunert mentioned this pull request May 12, 2021
Closed
12 tasks
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label May 12, 2021
@k8s-ci-robot k8s-ci-robot added language/en Issues or PRs related to English language sig/docs Categorizes an issue or PR as relevant to SIG Docs. labels May 12, 2021
@saschagrunert saschagrunert force-pushed the seccomp-default branch 2 times, most recently from d129b8e to 52b0e46 Compare May 12, 2021 11:23
@netlify
Copy link

netlify bot commented May 12, 2021

Deploy preview for kubernetes-io-master-staging ready!

Built with commit d02e3b2

https://deploy-preview-27957--kubernetes-io-master-staging.netlify.app

@netlify
Copy link

netlify bot commented May 12, 2021

Deploy preview for kubernetes-io-master-staging ready!

Built with commit 52b0e46

https://deploy-preview-27957--kubernetes-io-master-staging.netlify.app

sftim
sftim previously requested changes May 12, 2021
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@saschagrunert Remember to target branch dev-1.22, not master

@saschagrunert saschagrunert changed the base branch from master to dev-1.22 May 12, 2021 11:55
@k8s-ci-robot k8s-ci-robot added size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels May 12, 2021
sftim
sftim reviewed May 12, 2021
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Given that this tutorial is going to be about trying an alpha feature, let's reword:

This tutorial will show examples with both alpha (pre-v1.19) and generally available seccomp functionality

and also:

  • let min-kubernetes-server-version: 1.22 in the page front matter
  • add a {{< version-check >}} shortcode to the prerequisites section, plus extra text about setting up kind to run a v1.22 or later cluster with the feature gate enabled.

content/en/docs/tutorials/clusters/seccomp.md Outdated Show resolved Hide resolved
@k8sio-netlify-preview-bot
Copy link
Collaborator

k8sio-netlify-preview-bot commented May 12, 2021 •
edited by netlify bot

👷 Deploy Preview for kubernetes-io-vnext-staging processing.

🔨 Explore the source changes: 27a74df

🔍 Inspect the deploy log: https://app.netlify.com/sites/kubernetes-io-vnext-staging/deploys/60d48467d049870008d171e2

@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. labels May 12, 2021
@saschagrunert saschagrunert force-pushed the seccomp-default branch 6 times, most recently from 4e0217b to e52639e Compare May 12, 2021 12:31
@saschagrunert
Copy link
Member Author

Thank you for the review @sftim 🙏 ! I hope I understood and addressed your comments correctly.

@sftim sftim dismissed their stale review May 12, 2021 12:44

Superseded

sftim
sftim reviewed May 12, 2021
View reviewed changes
Copy link
Contributor

@sftim sftim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we be sure that kind will provide a tool that deploys a v1.22 cluster on or soon after release day?

I notice latest kind deploys a v1.20 cluster.

@saschagrunert
Copy link
Member Author

Can we be sure that kind will provide a tool that deploys a v1.22 cluster on or soon after release day?

I notice latest kind deploys a v1.20 cluster.

No, I assume that the images will be updated manually after a k8s release.

cc @BenTheElder

@saschagrunert saschagrunert force-pushed the seccomp-default branch 6 times, most recently from 3106eaf to 5746b63 Compare June 24, 2021 09:22
@saschagrunert
Copy link
Member Author

Thank you for the review, I had to mention the --seccomp-default kubelet flag too and added a link to the KEP for referring to the upgrade and downgrade strategy.

tengqm
tengqm reviewed Jun 24, 2021
View reviewed changes
content/en/docs/reference/command-line-tools-reference/feature-gates.md Outdated Show resolved Hide resolved
content/en/docs/tutorials/clusters/seccomp.md Outdated Show resolved Hide resolved
content/en/docs/tutorials/clusters/seccomp.md Outdated Show resolved Hide resolved
content/en/docs/tutorials/clusters/seccomp.md Outdated Show resolved Hide resolved
content/en/docs/tutorials/clusters/seccomp.md Outdated Show resolved Hide resolved
content/en/docs/tutorials/clusters/seccomp.md Outdated Show resolved Hide resolved
@saschagrunert saschagrunert force-pushed the seccomp-default branch 2 times, most recently from 9738b6f to de98ba2 Compare June 24, 2021 13:10
@saschagrunert
Add documentation about SeccompDefault feature
27a74df 
This adds a documentation section about the `SeccompDefault` feature
gate for the kubelet. Beside that, the feature gate has been added to
the list of features, too.

Signed-off-by: Sascha Grunert <sgrunert@redhat.com>
@saschagrunert
Copy link
Member Author

Thank you for the review @tengqm, I added and fixed your suggestions :)

@saschagrunert
Copy link
Member Author

k/k PR merged, this is now ready, too. A feature blog post with more background information is in progress, especially covering upgrade and downgrade strategies.

@tengqm
Copy link
Contributor

tengqm commented Jun 25, 2021

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 25, 2021
@k8s-ci-robot
Copy link
Contributor

LGTM label has been added.

Git tree hash: d58454a5d3d3e8786c65c0e4a449875ff59f5c5a

@saschagrunert
Copy link
Member Author

@kubernetes/sig-docs-en-owners please take a look

@carlisia
Copy link

/lgtm

@carlisia
Copy link

/approve

@carlisia
Copy link

/approved

@sftim
Copy link
Contributor

sftim commented Jun 28, 2021

I'll let the docs release team for v1.22 make the call on approval here.

@saschagrunert
Copy link
Member Author

I'll let the docs release team for v1.22 make the call on approval here.

Requesting approval from @PI-Victor @ashnehete @carlisia @chrisnegus @ritpanjw

@PI-Victor
Copy link
Member

thank you for your work @saschagrunert!

/approve

ps: had this written but forgot to press the button.

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: carlisia, PI-Victor

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 28, 2021
@k8s-ci-robot k8s-ci-robot merged commit 48c2535 into kubernetes:dev-1.22 Jun 28, 2021
@saschagrunert saschagrunert deleted the seccomp-default branch June 28, 2021 12:09
@BenTheElder
Copy link
Member

#27957 (comment) FTR kind create cluster --image=kindest/node:v1.22.0@sha256:b8bda84bb3a190e6e028b1760d277454a72267a5454b57db34437c34a588d047 works with the current stable release (kind v0.11.1) that has been out for some time, I'll be adding that image to the list of available images for that release and we'll be cutting a new release that defaults to v1.22 in the near future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kbhawkey kbhawkey kbhawkey left review comments

@tengqm tengqm tengqm left review comments

@pjbgf pjbgf pjbgf left review comments

@sftim sftim sftim left review comments

@onlydole onlydole Awaiting requested review from onlydole

Assignees

@carlisia carlisia

@kbhawkey kbhawkey

@tengqm tengqm

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. language/en Issues or PRs related to English language lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/docs Categorizes an issue or PR as relevant to SIG Docs. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
1.22
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@saschagrunert @k8sio-netlify-preview-bot @BenTheElder @PI-Victor @sftim @kbhawkey @k8s-ci-robot @tengqm @carlisia @pjbgf