Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Note needed in "Using a Service to Expose Your App > Step 3: Deleting a service" #46105

Open
rahul38888 opened this issue May 1, 2024 · 8 comments · May be fixed by #46292
Open

Note needed in "Using a Service to Expose Your App > Step 3: Deleting a service" #46105

rahul38888 opened this issue May 1, 2024 · 8 comments · May be fixed by #46292
Labels
language/en Issues or PRs related to English language needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. sig/docs Categorizes an issue or PR as relevant to SIG Docs.

Comments

@rahul38888
Copy link

rahul38888 commented May 1, 2024

Location

In Step 3: Deleting a service of Using a Service to Expose Your App wiki

Issue

There should be a note mentioning that after running kubectl delete service -l app=kubernetes-bootcamp command, it might take some time for the the cache to get cleared. As a side effect, people might see curl http://"$(minikube ip):$NODE_PORT" to return valid results. This might create confusion for some people like it did for me.

@k8s-ci-robot k8s-ci-robot added the needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. label May 1, 2024
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

SIG Docs takes a lead on issue triage for this website, but any Kubernetes member can accept issues by applying the triage/accepted label.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@thisisharrsh
Copy link
Contributor

/sig docs
/language en

@k8s-ci-robot k8s-ci-robot added sig/docs Categorizes an issue or PR as relevant to SIG Docs. language/en Issues or PRs related to English language labels May 1, 2024
@adityasamant25
Copy link
Contributor

Hi @rahul38888,
There is a step mentioned to ensure the service is deleted before verifying with the curl command.

Confirm that the Service is gone:
kubectl get services

Is this not sufficient? Do you suggest to emphasize the text on this step to make it clearer?

@vishalbidwe
Copy link
Contributor

Hi Team,

I have created the PR #46292 by adding note to clarify the service's expected results, addressing potential confusion among users till cache gets cleared.

Feel free to review and merge the PR

Thanks :)

@divya-mohan0209
Copy link
Contributor

@vishalbidwe : Thank you for your contribution. I would recommend that you go through our contribution guide before submitting any PR, because there are certain recommendations that we expect our contributors to know about. In this specific case, the PR was supposed to be submitted only if the issue had the triage/accepted label. This is because we do not have sufficient information at hand as to why the requester has submitted this despite having a line that explicitly states to confirm that the service is gone in the docs.

I'll be putting your PR on hold till we receive further response from the requester

@divya-mohan0209
Copy link
Contributor

@rahul38888 : Please could you advise why this extra line is needed?

@rahul38888
Copy link
Author

rahul38888 commented May 10, 2024

Sorry for the late reply.

@adityasamant25 Making sure service in not listed by kubectl get services is not enough. I have seen URL still working even after that. So there should be a note like the one #46292 by @vishalbidwe

@divya-mohan0209 , I think it make sense to have this note as it will provide a complete picture to readers.

@adityasamant25
Copy link
Contributor

@rahul38888 I have personally not experienced this behaviour. However, if you have experienced it and others can verify, then I do not see a harm in emphasizing about waiting for few seconds before the changes take effect.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
language/en Issues or PRs related to English language needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. sig/docs Categorizes an issue or PR as relevant to SIG Docs.
Projects
None yet
6 participants