Transfer go get to go install #290
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
the
cncf-cla: yes
k8s-ci-robot
added
the
size/XS
MadhavJivrajani
requested changes
Aug 30, 2023
|
@nitishfy after resolving the last comment, please squash commits and we should be good to go here :) |
nitishfy
force-pushed
the
Nitish/go-get-deprecated
branch
from
f5cc43d
to
8a6db1c
Compare
Done! |
MadhavJivrajani
approved these changes
Aug 30, 2023
k8s-ci-robot
added
the
lgtm
liggitt
reviewed
Aug 30, 2023
Signed-off-by: NitishKumar06 <justnitish06@gmail.com>
k8s-ci-robot
removed
the
lgtm
|
Sorry for the delay, this PR is ready for the next set of review. |
|
/approve |
k8s-ci-robot
added
the
lgtm
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dims, MadhavJivrajani, nitishfy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
What this PR does / why we need it:
go gethas been deprecated in Go for a few releases: https://go.dev/doc/go-get-install-deprecationhack/. A few of them still usego getI think, and we’re using go1.18 in the repo which should havego getdeprecated.Which issue(s) this PR fixes:
Fixes # N/A
Special notes for your reviewer:
N/A
Release note:
N/A