Add generic ptr.To, ptr.Deref, ptr.Equal #283
Merged
+271
−222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k8s-ci-robot
added
kind/feature
|
Welcome @skitt! |
k8s-ci-robot
added
the
size/L
This simplifies the implementation and adds support for pointers to enums and arbitrary types. To allow a complete migration from pointer to ptr, this also moves AllPtrFieldsNil. The ptr.AllPtrFieldsNil "ptr" repetition is preserved since the function only looks at pointer fields. Existing deprecation notices are updated to point to the new functions, and the pointer package as a whole is deprecated. Existing test code is preserved as-is to "prove" the correctness of the migration. This was mostly written by Aldo Culquicondor; see kubernetes#269 for context. Signed-off-by: Stephen Kitt <skitt@redhat.com>
k8s-ci-robot
added
the
lgtm
|
/hold |
k8s-ci-robot
added
the
do-not-merge/hold
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: alculquicondor, skitt, thockin The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
the
approved
|
/hold cancel The last 1.24 patch was released. |
k8s-ci-robot
removed
the
do-not-merge/hold
This was referenced Sep 11, 2023
|
@skitt could you mind I also work on "ptr.Deref" followed this PR ? any question please let me know, thanks. |
Please, go ahead! I’ve pushed all my pending changes, and I haven’t addressed |
|
@skitt I'd like to work on "ptr.Equal" |
This was referenced Sep 13, 2023
9 tasks
liangyuanpeng
added a commit
to liangyuanpeng/kubernetes
that referenced
this pull request
Apr 15, 2024
The new k8s.io/utils/ptr package provides generic wrapper functions, which can be used instead of type-specific pointer wrapper functions. This replaces the latter with the former, and migrates other uses of the deprecated pointer package to ptr in affacted files. See kubernetes/utils#283 for details. Signed-off-by: Lan Liang <gcslyp@gmail.com>
liangyuanpeng
added a commit
to liangyuanpeng/kubernetes
that referenced
this pull request
Apr 15, 2024
The new k8s.io/utils/ptr package provides generic wrapper functions, which can be used instead of type-specific pointer wrapper functions. This replaces the latter with the former, and migrates other uses of the deprecated pointer package to ptr in affacted files. See kubernetes/utils#283 for details. Signed-off-by: Lan Liang <gcslyp@gmail.com>
liangyuanpeng
added a commit
to liangyuanpeng/kubernetes
that referenced
this pull request
Apr 15, 2024
The new k8s.io/utils/ptr package provides generic wrapper functions, which can be used instead of type-specific pointer wrapper functions. This replaces the latter with the former, and migrates other uses of the deprecated pointer package to ptr in affacted files. See kubernetes/utils#283 for details. Signed-off-by: Lan Liang <gcslyp@gmail.com>
This was referenced Apr 15, 2024
liangyuanpeng
added a commit
to liangyuanpeng/kubernetes
that referenced
this pull request
Apr 15, 2024
The new k8s.io/utils/ptr package provides generic wrapper functions, which can be used instead of type-specific pointer wrapper functions. This replaces the latter with the former, and migrates other uses of the deprecated pointer package to ptr in affacted files. See kubernetes/utils#283 for details. Signed-off-by: Lan Liang <gcslyp@gmail.com>
liangyuanpeng
added a commit
to liangyuanpeng/kubernetes
that referenced
this pull request
Apr 15, 2024
The new k8s.io/utils/ptr package provides generic wrapper functions, which can be used instead of type-specific pointer wrapper functions. This replaces the latter with the former, and migrates other uses of the deprecated pointer package to ptr in affacted files. See kubernetes/utils#283 for details. Signed-off-by: Lan Liang <gcslyp@gmail.com>
liangyuanpeng
added a commit
to liangyuanpeng/kubernetes
that referenced
this pull request
Apr 15, 2024
The new k8s.io/utils/ptr package provides generic wrapper functions, which can be used instead of type-specific pointer wrapper functions. This replaces the latter with the former, and migrates other uses of the deprecated pointer package to ptr in affacted files. See kubernetes/utils#283 for details. Signed-off-by: Lan Liang <gcslyp@gmail.com>
liangyuanpeng
added a commit
to liangyuanpeng/kubernetes
that referenced
this pull request
Apr 16, 2024
The new k8s.io/utils/ptr package provides generic wrapper functions, which can be used instead of type-specific pointer wrapper functions. This replaces the latter with the former, and migrates other uses of the deprecated pointer package to ptr in affacted files. See kubernetes/utils#283 for details. Signed-off-by: Lan Liang <gcslyp@gmail.com>
liangyuanpeng
added a commit
to liangyuanpeng/kubernetes
that referenced
this pull request
Apr 17, 2024
The new k8s.io/utils/ptr package provides generic wrapper functions, which can be used instead of type-specific pointer wrapper functions. This replaces the latter with the former, and migrates other uses of the deprecated pointer package to ptr in affacted files. See kubernetes/utils#283 for details. Signed-off-by: Lan Liang <gcslyp@gmail.com>
jingczhang
pushed a commit
to nokia/kubernetes
that referenced
this pull request
May 7, 2024
The new k8s.io/utils/ptr package provides generic wrapper functions, which can be used instead of type-specific pointer wrapper functions. This replaces the latter with the former, and migrates other uses of the deprecated pointer package to ptr in affacted files. See kubernetes/utils#283 for details. Signed-off-by: Lan Liang <gcslyp@gmail.com>
liangyuanpeng
added a commit
to liangyuanpeng/karmada
that referenced
this pull request
May 28, 2024
…nce a pointer. The new k8s.io/utils/ptr package provides generic wrapper functions, which can be used instead of type-specific pointer wrapper functions. This replaces the latter with the former, and migrates other uses of the deprecated pointer package to ptr in affacted files. See kubernetes/utils#283 for details. Signed-off-by: Lan Liang <gcslyp@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/kind feature
What this PR does / why we need it:
This adds a
ptrpackage containing generic equivalents of thepointerfunctions:ptr.To,ptr.Derefandptr.Equal. This simplifies the implementation and adds support for pointers to enums and arbitrary types.To allow a complete migration from
pointertoptr, this also movesAllPtrFieldsNil. Theptr.AllPtrFieldsNil"ptr" repetition is preserved since the function only looks at pointer fields.Existing deprecation notices are updated to point to the new functions, and the pointer package as a whole is deprecated. Existing test code is preserved as-is to "prove" the correctness of the migration.
This was mostly written by @alculquicondor ; see #269 for context.
Which issue(s) this PR fixes:
Special notes for your reviewer:
Release note: