-
Notifications
You must be signed in to change notification settings - Fork 188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add LockWithContext method to keymutex #281
feat: Add LockWithContext method to keymutex #281
Conversation
Welcome @DerekTBrown! |
/retest |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: DerekTBrown The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@MadhavJivrajani I updated the PR to pass the linter.
What are the next steps for reviewing/approving this change? |
The Kubernetes project currently lacks enough contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle stale |
The Kubernetes project currently lacks enough active contributors to adequately respond to all PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /lifecycle rotten |
The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs. This bot triages PRs according to the following rules:
You can:
Please send feedback to sig-contributor-experience at kubernetes/community. /close |
@k8s-triage-robot: Closed this PR. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
What type of PR is this?
/kind feature
What this PR does / why we need it:
KeyMutex
doesn't provide cancellation/timeout functionality. This results in poor behavior (unnecessary lock contention), and increases the complexity of the required caller implementation (caller must determine whether to immediately return lock if context is cancelled, etc).LockWithContext
method toKeyMutex
, which allows callers to more gracefully implement acquisition cancellation/timeouts.Mutex
to achan
. This is required becauseMutex
doesn't have support forselect
or other conditional acquisition (timeouts) short of polling.Which issue(s) this PR fixes:
This is a new feature. Please let me know if I need to create a corresponding issue.
Special notes for your reviewer:
Release note: