add uint64 and uint to pointer pkg

[kschoche]

What type of PR is this?
/kind feature

What this PR does / why we need it:
This PR adds support for interacting with 32 and 64bit unsigned ints in the pointer package.
We wanted to standardize on the pointer package but found that it was lacking unsigned int support which is commonly used in k8s and applications interacting with k8s.

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:
I'm not 100% sure if it makes sense to add the back-compatibility pieces which I copied from the existing Intand Int64 implementations. If not I can back them out and just leave the new pieces.

Release note:

[linux-foundation-easycla]

The committers listed above are authorized under a signed CLA.

• ✅ login: kschoche / name: Kyle Schochenmaier (d45ae35)

[k8s-ci-robot]

Welcome @kschoche!

It looks like this is your first PR to kubernetes/utils 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/utils has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

[apelisse]

I'd sort of expect all these things to now be defined by golang since I'm assuming they can be implemented with generics?

[kschoche]

I'd sort of expect all these things to now be defined by golang since I'm assuming they can be implemented with generics?

Hi @apelisse, thanks for the reply!
I had seen that there have been some PRs already that attempted to introduce generics to the pointer package PR but it seems like there were some blockers with the requirements for using go 1.18. Is that still the case? If so, I'm wondering what to do in the meantime for those of us who may also have the same concerns?

The use case I'm trying to address is to provide coverage in the pointer package for Uint64 as we are trying to use it with some CRD code that uses it for things like versions and timestamps.

I do understand that an obvious+easy answer is for users to BYO functionality, which is what we already do, and so this PR is more of a "nice to have" vs a necessity.

Thoughts?
Thanks!
~Kyle

[apelisse]

I guess I don't see any problem with this PR being merged in the mean time.

Where do you need this code? Or is it strictly hypothetical?

[kschoche]

Cool.
I ran into this while doing some code cleanup on hashicorp/consul-k8s where we've to date just been rolling our own version of the pointer pkg for interacting with CR specs in our CRD controllers. Right now if I could get this merged then I could fully move over to pointer.

[kschoche]

Hi @apelisse - sorry for the ping here, but I just wanted to double-check if there were any additional changes you might see needed for this PR while it's fresh in my mind. Cheers.

[apelisse]

Sorry, I missed your reply.

/lgtm
/approve

[k8s-ci-robot]

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: apelisse, kschoche

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• pointer/OWNERS [apelisse]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment