Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix repository for VPA presubmit tests #32607

Merged

Conversation

voelzmo
Copy link
Contributor

@voelzmo voelzmo commented May 13, 2024

The VPA presubmit tests for PRs introduced with #30994 did never run despite multiple PRs being raised in the meantime. This seems to be the case, because the triggering condition is never met, as it is checked against k/k, not against k/autoscaler.

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label May 13, 2024
@k8s-ci-robot k8s-ci-robot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/config Issues or PRs related to code in /config area/jobs sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels May 13, 2024
Copy link
Contributor

@jackfrancis jackfrancis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

(fyi I don't have any privilges here)

/assign @MaciekPytel @bskiba

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 13, 2024
@bskiba
Copy link
Member

bskiba commented May 14, 2024

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 14, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bskiba, jackfrancis, voelzmo

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 978bc73 into kubernetes:master May 14, 2024
7 checks passed
@k8s-ci-robot
Copy link
Contributor

@voelzmo: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key sig-autoscaling-presubmits.yaml using file config/jobs/kubernetes/sig-autoscaling/sig-autoscaling-presubmits.yaml

In response to this:

The VPA presubmit tests for PRs introduced with #30994 did never run despite multiple PRs being raised in the meantime. This seems to be the case, because the triggering condition is never met, as it is checked against k/k, not against k/autoscaler.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants