-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add gke option to create nat before the cluster #32597
Conversation
Hi @hbostan. Thanks for your PR. I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/assign @aojea |
have you tested this change locally? |
Yes, tested locally and it works as expected |
/ok-to-test This is a one off exception since is feature gated with a flag, please try to move to kubetest2 in the future as this is no longer maintained and deprecated for several years now |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: aojea, hbostan The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Added a new flag to
gkeDeployer
to create the router and NAT before creating the cluster. This is done because with large enough number of nodes, nat creation can cause some timeouts.