-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add image pushing job for cloud provider vsphere #32590
Add image pushing job for cloud provider vsphere #32590
Conversation
XudongLiuHarold
commented
May 9, 2024
- Add image pushing job for cloud provider vsphere
9f7ce7c
to
ac20e62
Compare
Hi @ameukam, could you review this one when you are available? Thank you! ❤️ |
/assign @ameukam @test-infra-oncall |
@XudongLiuHarold: GitHub didn't allow me to assign the following users: test-infra-oncall. Note that only kubernetes members with read permissions, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One nit, otherwise looks perfect
config/jobs/image-pushing/k8s-staging-cloud-provider-vsphere.yaml
Outdated
Show resolved
Hide resolved
Signed-off-by: xudong liu <xudong.liu@broadcom.com>
ac20e62
to
dfb20a0
Compare
Thx! /assign @dims (Context: this is part of our work to move to community infra) |
/approve Remove the hold when ready. |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ameukam, XudongLiuHarold The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
/hold cancel |
@XudongLiuHarold: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |