-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
config/secret: deflake TestAddWithParser #32384
base: master
Are you sure you want to change the base?
config/secret: deflake TestAddWithParser #32384
Conversation
This commit does 2 main things to deflake TestAddWithParser: 1. Ensure that we wait a sufficient amount for the secret to be reoloaded. 2. Try using the last modification time of the initial secret parse. Without this, the parsing function used in the test ends up with duplicates in the channel and we get flakes. Signed-off-by: Madhav Jivrajani <madhav.jiv@gmail.com>
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: MadhavJivrajani The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@stevekuznetsov / @petr-muller could you also help take a look? |
/hold |
@MadhavJivrajani: The following tests failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
This commit does 2 main things to deflake TestAddWithParser:
Fixes #31313
/assign @alvaroaleman
as the original author of this part of the codebase