Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

config/secret: deflake TestAddWithParser #32384

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

MadhavJivrajani
Copy link
Contributor

@MadhavJivrajani MadhavJivrajani commented Apr 5, 2024

This commit does 2 main things to deflake TestAddWithParser:

  1. Ensure that we wait a sufficient amount for the secret to be reoloaded.
  2. Try using the last modification time of the initial secret parse. Without this, the parsing function used in the test ends up with duplicates in the channel and we get flakes.
❯ stress ./secret.test -test.run=^TestAddWithParser$
5s: 16 runs so far, 0 failures
10s: 32 runs so far, 0 failures
15s: 48 runs so far, 0 failures
20s: 64 runs so far, 0 failures
25s: 80 runs so far, 0 failures
30s: 96 runs so far, 0 failures
35s: 112 runs so far, 0 failures
40s: 128 runs so far, 0 failures
45s: 144 runs so far, 0 failures
50s: 160 runs so far, 0 failures
55s: 180 runs so far, 0 failures
1m0s: 208 runs so far, 0 failures
1m5s: 224 runs so far, 0 failures
1m10s: 240 runs so far, 0 failures
1m15s: 256 runs so far, 0 failures
1m20s: 272 runs so far, 0 failures
1m25s: 288 runs so far, 0 failures
1m30s: 304 runs so far, 0 failures
1m35s: 320 runs so far, 0 failures
1m40s: 336 runs so far, 0 failures
1m45s: 356 runs so far, 0 failures
1m50s: 384 runs so far, 0 failures
1m55s: 400 runs so far, 0 failures
2m0s: 416 runs so far, 0 failures
2m5s: 432 runs so far, 0 failures
2m10s: 448 runs so far, 0 failures
2m15s: 464 runs so far, 0 failures
2m20s: 480 runs so far, 0 failures
2m25s: 496 runs so far, 0 failures
2m30s: 512 runs so far, 0 failures
2m35s: 532 runs so far, 0 failures
2m40s: 560 runs so far, 0 failures
2m45s: 576 runs so far, 0 failures
2m50s: 592 runs so far, 0 failures
2m55s: 608 runs so far, 0 failures
3m0s: 624 runs so far, 0 failures

Fixes #31313

/assign @alvaroaleman
as the original author of this part of the codebase

This commit does 2 main things to deflake TestAddWithParser:
1. Ensure that we wait a sufficient amount for the secret to
   be reoloaded.
2. Try using the last modification time of the initial secret parse.
   Without this, the parsing function used in the test ends up with
   duplicates in the channel and we get flakes.

Signed-off-by: Madhav Jivrajani <madhav.jiv@gmail.com>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. area/prow Issues or PRs related to prow sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Apr 5, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: MadhavJivrajani
Once this PR has been reviewed and has the lgtm label, please assign petr-muller for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@MadhavJivrajani
Copy link
Contributor Author

@stevekuznetsov / @petr-muller could you also help take a look?

@MadhavJivrajani
Copy link
Contributor Author

/hold
Getting back to the above failure in a bit ^

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Apr 5, 2024
@k8s-ci-robot
Copy link
Contributor

@MadhavJivrajani: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-test-infra-unit-test 3898c4f link true /test pull-test-infra-unit-test
pull-test-infra-unit-test-race-detector-nonblocking 3898c4f link false /test pull-test-infra-unit-test-race-detector-nonblocking

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/prow Issues or PRs related to prow cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[flake] unit test TestAddWithParser
3 participants