Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update deps for sigs.k8s.io/controller-runtime@v0.16.3 - step 1 #32330

Open
wants to merge 14 commits into
base: master
Choose a base branch
from

Conversation

danilo-gemoli
Copy link
Contributor

This PR is part of the sigs.k8s.io/controller-runtime@v0.16.3 upgrade effort.
Check the issue at #32328

The following modules have been updated:

  • github.com/emicklei/go-restful/v3@v3.11.0
  • github.com/evanphx/json-patch@v5.6.0+incompatible
  • github.com/fsnotify/fsnotify@v1.6.0
  • github.com/go-kit/log@v0.2.1
  • github.com/go-logr/zapr@v1.2.4
  • github.com/go-openapi/jsonreference@v0.20.2
  • github.com/google/gnostic-models@v0.6.8

github.com/google/gnostic-models@v0.6.8 is being removed as soon as go mod tidy is issued. I guess that's why at this point it is just an indirect dependency not being used by anyone/anything.

/label tide/merge-method-squash

@k8s-ci-robot k8s-ci-robot added tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Mar 28, 2024
@petr-muller
Copy link
Member

/retitle chore: update deps for sigs.k8s.io/controller-runtime@v0.16.3 - step 1
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot changed the title chore: update sigs.k8s.io/controller-runtime@v0.16.3 - step 1 chore: update deps for sigs.k8s.io/controller-runtime@v0.16.3 - step 1 Mar 28, 2024
@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 28, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: danilo-gemoli, petr-muller
Once this PR has been reviewed and has the lgtm label, please assign ameukam for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Apr 10, 2024
@k8s-ci-robot
Copy link
Contributor

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. tide/merge-method-squash Denotes a PR that should be squashed by tide when it merges.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants