Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CAPI Operator: Add damdo and furkatgofurov7 to OWNERS #29774

Merged
merged 1 commit into from Jun 16, 2023
Merged

CAPI Operator: Add damdo and furkatgofurov7 to OWNERS #29774

merged 1 commit into from Jun 16, 2023

Conversation

furkatgofurov7
Copy link
Member

also sort reviewers/approvers list alphabetically

/cc @damdo

@k8s-ci-robot
Copy link
Contributor

@furkatgofurov7: GitHub didn't allow me to request PR reviews from the following users: damdo.

Note that only kubernetes members and repo collaborators can review this PR, and authors cannot review their own PRs.

In response to this:

also sort reviewers/approvers list alphabetically

/cc @damdo

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/config Issues or PRs related to code in /config area/jobs sig/testing Categorizes an issue or PR as relevant to SIG Testing. do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. labels Jun 12, 2023
@furkatgofurov7
Copy link
Member Author

@alexander-demicev @Fedosin @JoelSpeed

@furkatgofurov7
Copy link
Member Author

The following users are mentioned in OWNERS file(s) but are untrusted for the following reasons. One way to make the user trusted is to add them as members of the kubernetes org. You can then trigger verification by writing /verify-owners in a comment.

  • damdo

    • User is not a member of the org. Satisfy at least one of these conditions to make the user trusted.
    • config/jobs/kubernetes-sigs/cluster-api-operator/OWNERS

should be fixed once kubernetes/org#4283 is closed

@furkatgofurov7 furkatgofurov7 changed the title Add damdo and furkatgofurov7 to CAPI Operator owners CAPI OperatorAdd damdo and furkatgofurov7 to owners Jun 12, 2023
@furkatgofurov7 furkatgofurov7 changed the title CAPI OperatorAdd damdo and furkatgofurov7 to owners CAPI Operator: Add damdo and furkatgofurov7 to OWNERS Jun 12, 2023
@furkatgofurov7
Copy link
Member Author

/test all

@furkatgofurov7
Add damdo and furkatgofurov7 to CAPI Operator owners
10f09e9 
Signed-off-by: Furkat Gofurov <furkat.gofurov@suse.com>
@furkatgofurov7
Copy link
Member Author

/verify-owners

damdo
damdo reviewed Jun 16, 2023
View reviewed changes
Copy link
Member

@damdo damdo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Thanks @furkatgofurov7

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 16, 2023
@furkatgofurov7
Copy link
Member Author

furkatgofurov7 commented Jun 16, 2023 •
edited

The following users are mentioned in OWNERS file(s) but are untrusted for the following reasons. One way to make the user trusted is to add them as members of the kubernetes org. You can then trigger verification by writing /verify-owners in a comment.

  • damdo

    • User is not a member of the org. Satisfy at least one of these conditions to make the user trusted.
    • config/jobs/kubernetes-sigs/cluster-api-operator/OWNERS

strange, I can tag @damdo on other PR #29741 (comment) meaning he is a member of k8s org, but this still complains..

Edit: works now

@furkatgofurov7
Copy link
Member Author

/cc @dims can you please help merging this? Thank you!

@furkatgofurov7
Copy link
Member Author

/verify-owners

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/invalid-owners-file Indicates that a PR should not merge because it has an invalid OWNERS file in it. label Jun 16, 2023
@dims
Copy link
Member

dims commented Jun 16, 2023

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: dims, furkatgofurov7

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jun 16, 2023
@k8s-ci-robot k8s-ci-robot merged commit 62c8863 into kubernetes:master Jun 16, 2023
4 checks passed
@furkatgofurov7 furkatgofurov7 deleted the update-capi-operator-owners branch June 16, 2023 12:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@damdo damdo damdo left review comments

Assignees

@damdo damdo

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@furkatgofurov7 @k8s-ci-robot @dims @damdo