Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add nodeoutofservicevolumedetach e2e test #26947

Merged
merged 1 commit into from Sep 22, 2022
Merged

add nodeoutofservicevolumedetach e2e test #26947

merged 1 commit into from Sep 22, 2022

Conversation

sonasingh46
Copy link
Contributor

Signed-off-by: Ashutosh Kumar sonasingh46@gmail.com
Add e2e test for NodeOutOfServiceVolumeDetach feature.
Ref: kubernetes/kubernetes#108486

@k8s-ci-robot k8s-ci-robot added the cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. label Jul 28, 2022
@k8s-ci-robot
Copy link
Contributor

Welcome @sonasingh46!

It looks like this is your first PR to kubernetes/test-infra 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/test-infra has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

Hi @sonasingh46. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. area/config Issues or PRs related to code in /config area/jobs area/provider/gcp Issues or PRs related to gcp provider sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jul 28, 2022
@ameukam
Copy link
Member

ameukam commented Jul 28, 2022

/ok-to-test

@k8s-ci-robot k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Jul 28, 2022
palnabarun
palnabarun reviewed Jul 28, 2022
View reviewed changes
config/jobs/kubernetes/sig-cloud-provider/gcp/gcp-gce.yaml Outdated
testgrid-dashboards: google-gce, google-gci, provider-gcp-periodics
testgrid-tab-name: nongraceful-node-shutdown
testgrid-num-failures-to-alert: '6'
testgrid-alert-email: release-team@kubernetes.io
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

release-team@kubernetes.io wouldn't need to be alerted for failures of this. Maybe some cloud provider team?

@xing-yang
Copy link
Contributor

/assign @mattcary

@mattcary Can you take a look? Thanks.

@xing-yang
Copy link
Contributor

/assign @andrewsykim

@xing-yang
Copy link
Contributor

/assign @cheftako

@xing-yang
Copy link
Contributor

/assign @msau42

@xing-yang
Copy link
Contributor

/assign @dims

msau42
msau42 reviewed Sep 20, 2022
View reviewed changes
config/jobs/kubernetes/sig-cloud-provider/gcp/gcp-gce.yaml Outdated
@@ -445,6 +445,51 @@ presubmits:
privileged: true

periodics:
- interval: 168h # one week
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add this to the existing alpha features job?

test-infra/config/jobs/kubernetes/sig-cloud-provider/gcp/gcp-gce.yaml

Line 340 in 72c610f

- name: pull-kubernetes-e2e-gce-alpha-features

You may also need to add the "ginkgo-parallel=1" flag since the test is disruptive.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@msau42 This job "pull-kubernetes-e2e-gce-alpha-features" skips all sig-storage tests.
https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/111373/pull-kubernetes-e2e-gce-alpha-features/1572235414100512768/

The non-graceful node shutdown test is added under e2e/storage so it is also skipped:

Kubernetes e2e suite: [It] [sig-storage] [Feature:NodeOutOfServiceVolumeDetach] [Disruptive] [LinuxOnly] NonGracefulNodeShutdown [NonGracefulNodeShutdown] pod that uses a persistent volume via gce pd driver should get immediately rescheduled to a different node after non graceful node shutdown

Reason: skipped

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see anything in the skip setting that would cause that test to be skipped:

---test_args=--ginkgo.focus=\[Feature:(GRPCContainerProbe|InPlacePodVerticalScaling|ProbeTerminationGracePeriod|APIServerTracing|StorageVersionAPI|PodPreset|StatefulSetMinReadySeconds|CustomResourceValidationExpressions|ProxyTerminatingEndpoints)\]|Networking --ginkgo.skip=\[Feature:(SCTPConnectivity|Volumes|Networking-Performance)\]|IPv6|csi-hostpath-v0

With the alpha-features test suite, you need an explicit focus to opt-in the test case.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, we'll remove this job and just add the new test to the "pull-kubernetes-e2e-gce-alpha-features" job.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@xing-yang @msau42 -- Opened a new PR #27600
Will close this once that gets merged. PTAL

andrewsykim
andrewsykim reviewed Sep 20, 2022
View reviewed changes
Copy link
Member

@andrewsykim andrewsykim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: andrewsykim, sonasingh46

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Sep 20, 2022
@k8s-ci-robot k8s-ci-robot added needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Sep 22, 2022
@sonasingh46
add nodeoutofservicevolumedetach e2e test
4a054dc 
Signed-off-by: Ashutosh Kumar <sonasingh46@gmail.com>
@k8s-ci-robot k8s-ci-robot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 22, 2022
@msau42
Copy link
Member

msau42 commented Sep 22, 2022

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Sep 22, 2022
@k8s-ci-robot k8s-ci-robot merged commit 47e80ca into kubernetes:master Sep 22, 2022
@k8s-ci-robot
Copy link
Contributor

@sonasingh46: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key gcp-gce.yaml using file config/jobs/kubernetes/sig-cloud-provider/gcp/gcp-gce.yaml

In response to this:

Signed-off-by: Ashutosh Kumar sonasingh46@gmail.com
Add e2e test for NodeOutOfServiceVolumeDetach feature.
Ref: kubernetes/kubernetes#108486

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xing-yang xing-yang xing-yang left review comments

@palnabarun palnabarun palnabarun left review comments

@andrewsykim andrewsykim andrewsykim left review comments

@msau42 msau42 msau42 left review comments

@cheftako cheftako Awaiting requested review from cheftako

@wojtek-t wojtek-t Awaiting requested review from wojtek-t

Assignees

@dims dims

@cheftako cheftako

@andrewsykim andrewsykim

@msau42 msau42

@mattcary mattcary

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs area/provider/gcp Issues or PRs related to gcp provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. ok-to-test Indicates a non-member PR verified by an org member that is safe to test. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
10 participants
@sonasingh46 @k8s-ci-robot @ameukam @xing-yang @msau42 @palnabarun @andrewsykim @dims @cheftako @mattcary