Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

verify-govet-levee: revert test image bump to use go1.18.3 #26931

Merged
merged 1 commit into from
Jul 27, 2022

Conversation

nikhita
Copy link
Member

@nikhita nikhita commented Jul 27, 2022

Ref: kubernetes/kubernetes#111452

This PR reverts the test image bump to go back to using go1.18.3. Using the go1.19rc2 image leads to test failures which is now blocking master.

See 8b92c5c#diff-d1fbb791428748a3ac059cce6d068e946557499654010d24494baf1a24bc2b05 for the details of the revert.

#26932 avoids autobumping the job until the Go team fixes the core issue.

cc @MadhavJivrajani @dims @palnabarun

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. area/config Issues or PRs related to code in /config area/jobs sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jul 27, 2022
@serathius
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 27, 2022
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: nikhita, serathius

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 27, 2022
@k8s-ci-robot k8s-ci-robot merged commit a7f16ec into kubernetes:master Jul 27, 2022
@k8s-ci-robot k8s-ci-robot added this to the v1.25 milestone Jul 27, 2022
@k8s-ci-robot
Copy link
Contributor

@nikhita: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key verify-govet-levee.yaml using file config/jobs/kubernetes/sig-instrumentation/verify-govet-levee.yaml

In response to this:

Ref: kubernetes/kubernetes#111452

This PR reverts the test image bump to go back to using go1.18.3. Using the go1.19rc2 image leads to test failures which is now blocking master.

See 8b92c5c#diff-d1fbb791428748a3ac059cce6d068e946557499654010d24494baf1a24bc2b05 for the details of the revert.

#26932 avoids autobumping the job until the Go team fixes the core issue.

cc @MadhavJivrajani @dims @palnabarun

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/instrumentation Categorizes an issue or PR as relevant to SIG Instrumentation. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants