-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Clean up upgrade/downgrade test configs #22915
Conversation
c0fa391
to
c741dd5
Compare
@@ -178,65 +178,4 @@ periodics: | |||
|
|||
annotations: | |||
testgrid-dashboards: google-gce-upgrade | |||
testgrid-tab-name: gce-gpu-1.13-master-master-upgrade | |||
- cron: "0 10-23/12 * * *" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why we're removing these?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
because the upgrade tests are the priority, and the downgrade tests are solidly failing (so no one is paying attention to the signal from them)
c741dd5
to
0da0b63
Compare
/approve Seems that bazel is failing. |
0da0b63
to
f74e52a
Compare
found/fixed a duplicate config and added job descriptions |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/approve
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: liggitt, spiffxp, wojtek-t The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
@liggitt: Updated the
In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
+1, downgrade tests have been poorly maintained to completely unmaintained since 1.13 or so. Ultimately, this is a signal that our community doesn't really care about downgrades, at least not for core canonical Kubernetes. If someone does care, maybe they'll step forwards to maintain the jobs. |
This is strange, because clearly I see some runs in prow: It seems like testgrid-related issue... |
OK - it seems it works now |
xref kubernetes/kubernetes#103697
/assign @spiffxp