Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up upgrade/downgrade test configs #22915

Merged
merged 3 commits into from
Jul 16, 2021

Conversation

liggitt
Copy link
Member

@liggitt liggitt commented Jul 16, 2021

xref kubernetes/kubernetes#103697

  • Removes solidly failing downgrade tests
  • Changes stable1 / beta tests to use stable1 / latest, since the latest marker file is actually maintained
    • if there was already a stable1 / latest test, drop the stable1 / beta test
  • Renames testgrid tabs to match reality of what is being tested (so we don't link to "1.13-1.14" tabs, which look obsolete)
  • Adds human-readable job descriptions

/assign @spiffxp

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. labels Jul 16, 2021
@k8s-ci-robot k8s-ci-robot added area/config Issues or PRs related to code in /config area/jobs area/provider/gcp Issues or PRs related to gcp provider sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jul 16, 2021
@@ -178,65 +178,4 @@ periodics:

annotations:
testgrid-dashboards: google-gce-upgrade
testgrid-tab-name: gce-gpu-1.13-master-master-upgrade
- cron: "0 10-23/12 * * *"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why we're removing these?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

because the upgrade tests are the priority, and the downgrade tests are solidly failing (so no one is paying attention to the signal from them)

@wojtek-t
Copy link
Member

/approve

Seems that bazel is failing.

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 16, 2021
@liggitt
Copy link
Member Author

liggitt commented Jul 16, 2021

found/fixed a duplicate config and added job descriptions

Copy link
Member

@spiffxp spiffxp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/approve
/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 16, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: liggitt, spiffxp, wojtek-t

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 2682bd3 into kubernetes:master Jul 16, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Jul 16, 2021
@k8s-ci-robot
Copy link
Contributor

@liggitt: Updated the job-config configmap in namespace default at cluster test-infra-trusted using the following files:

  • key sig-cli-config.yaml using file config/jobs/kubernetes/sig-cli/sig-cli-config.yaml
  • key gcp-gpu-upgrade-downgrade.yaml using file config/jobs/kubernetes/sig-cloud-provider/gcp/gpu/gcp-gpu-upgrade-downgrade.yaml
  • key upgrade-gce.yaml using file config/jobs/kubernetes/sig-cloud-provider/gcp/upgrade-gce.yaml

In response to this:

xref kubernetes/kubernetes#103697

  • Removes solidly failing downgrade tests
  • Changes stable1 / beta tests to use stable1 / latest, since the latest marker file is actually maintained
  • if there was already a stable1 / latest test, drop the stable1 / beta test
  • Renames testgrid tabs to match reality of what is being tested (so we don't link to "1.13-1.14" tabs, which look obsolete)
  • Adds human-readable job descriptions

/assign @spiffxp

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@spiffxp
Copy link
Member

spiffxp commented Jul 16, 2021

For anyone following along, a consequence of this is that it looks like we "lost" history from some of our infra's perspective (like testgrid or triage). Our infra doesn't understand the concept of renames, so they instead look like old jobs going away, and new jobs starting fresh with no history. The old job data necessary to regenerate history is still present in GCS, but it's at an old location not associated with the new job.

This is why testgrid shows a bunch of jobs with no results right now
Screen Shot 2021-07-16 at 2 14 46 PM

@wojtek-t
Copy link
Member

@liggitt @spiffxp - actually, it seems that something might have gone wrong - we still don't have any runs of those 3 days later...

@jberkus
Copy link
Contributor

jberkus commented Jul 19, 2021

+1, downgrade tests have been poorly maintained to completely unmaintained since 1.13 or so. Ultimately, this is a signal that our community doesn't really care about downgrades, at least not for core canonical Kubernetes. If someone does care, maybe they'll step forwards to maintain the jobs.

@liggitt
Copy link
Member Author

liggitt commented Jul 20, 2021

@liggitt @spiffxp - actually, it seems that something might have gone wrong - we still don't have any runs of those 3 days later...

that's... unexpected... did I miss something here?

@wojtek-t
Copy link
Member

This is strange, because clearly I see some runs in prow:
https://prow.k8s.io/?job=ci-kubernetes-e2e-gce-stable1-latest-upgrade-cluster

It seems like testgrid-related issue...

@wojtek-t
Copy link
Member

OK - it seems it works now

@liggitt liggitt deleted the beta-master-upgrade branch July 21, 2021 13:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/config Issues or PRs related to code in /config area/jobs area/provider/gcp Issues or PRs related to gcp provider cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cli Categorizes an issue or PR as relevant to SIG CLI. sig/cloud-provider Categorizes an issue or PR as relevant to SIG Cloud Provider. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants