Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow spyglass to use cookie auth #16491

Merged
merged 1 commit into from
Mar 4, 2020
Merged

Allow spyglass to use cookie auth #16491

merged 1 commit into from
Mar 4, 2020

Conversation

fejta
Copy link
Contributor

@fejta fejta commented Feb 26, 2020 •
edited

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/L Denotes a PR that changes 100-499 lines, ignoring generated files. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Feb 26, 2020
@k8s-ci-robot k8s-ci-robot added area/prow Issues or PRs related to prow area/prow/deck Issues or PRs related to prow's deck component area/prow/spyglass Issues or PRs related to prow's spyglass UI sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Feb 26, 2020
@fejta
Copy link
Contributor Author

fejta commented Mar 2, 2020

Can I get a review please?

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Mar 4, 2020
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fejta, Katharine

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@fejta
Copy link
Contributor Author

fejta commented Mar 4, 2020

/retest

1 similar comment
@fejta
Copy link
Contributor Author

fejta commented Mar 4, 2020

/retest

@fejta
Copy link
Contributor Author

fejta commented Mar 4, 2020

@alvaroaleman I'm inclined to revert #16362

@k8s-ci-robot k8s-ci-robot merged commit 34d7713 into kubernetes:master Mar 4, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.18 milestone Mar 4, 2020
@fejta fejta deleted the rev branch March 4, 2020 22:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Katharine Katharine Katharine approved these changes

@krzyzacy krzyzacy Awaiting requested review from krzyzacy

@michelle192837 michelle192837 Awaiting requested review from michelle192837

Assignees

@Katharine Katharine

@cjwagner cjwagner

@stevekuznetsov stevekuznetsov

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/prow/deck Issues or PRs related to prow's deck component area/prow/spyglass Issues or PRs related to prow's spyglass UI area/prow Issues or PRs related to prow cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/L Denotes a PR that changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
v1.18
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@fejta @k8s-ci-robot @Katharine @cjwagner @stevekuznetsov