Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[flake] unit test TestAddWithParser #31313

Open
aojea opened this issue Nov 24, 2023 · 10 comments · May be fixed by #32384, #32385 or kubernetes-sigs/prow#110
Open

[flake] unit test TestAddWithParser #31313

aojea opened this issue Nov 24, 2023 · 10 comments · May be fixed by #32384, #32385 or kubernetes-sigs/prow#110
Assignees
@MadhavJivrajani
Labels
area/prow Issues or PRs related to prow kind/flake Categorizes issue or PR as related to a flaky test. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one.

Comments

@aojea
Copy link
Member

aojea commented Nov 24, 2023 •
edited by stevekuznetsov 

          is this related?
k8s.io/test-infra/prow/config/secret: TestAddWithParser/1 expand_less 2s
{Failed === RUN TestAddWithParser/1 === PAUSE TestAddWithParser/1 === CONT TestAddWithParser/1 time="2023-XX-24TXX:X2:00Z" level=warning msg="Error loading secret file." error="stat /tmp/X742X67904: no such file or directory" secret-path=/tmp/X742X67904 time="2023-XX-24TXX:X2:00Z" level=warning msg="Error loading secret file." error="stat /tmp/3086003526: no such file or directory" secret-path=/tmp/3086003526 agent_test.go:169: expected value 2 from generator, got 1 time="X0X3-11-X4T11:1X:01Z" level=error msg="Error loading secret." error="strconv.Atoi: parsing "not-a-number": invalid syntax" secret-path=/tmp/TestAddWithParser0360X481105/001/secret --- FAIL: TestAddWithParser/1 (2.00s)

https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/test-infra/31312/pull-test-infra-unit-test/1728007651314372608

Originally posted by @aojea in #31312 (comment)

=== RUN TestAddWithParser/1
 === PAUSE TestAddWithParser/1
 === CONT TestAddWithParser/1
time="2023-XX-24TXX:X2:00Z" level=warning msg="Error loading secret file." error="stat /tmp/X742X67904: no such file or directory" secret-path=/tmp/X742X67904
time="2023-XX-24TXX:X2:00Z" level=warning msg="Error loading secret file." error="stat /tmp/3086003526: no such file or directory" secret-path=/tmp/3086003526
 agent_test.go:169: expected value 2 from generator, got 1
time="X0X3-11-X4T11:1X:01Z" level=error msg="Error loading secret." error="strconv.Atoi: parsing "not-a-number": invalid syntax" secret-path=/tmp/TestAddWithParser0360X481105/001/secret
 --- FAIL: TestAddWithParser/1 (2.00s)
@k8s-ci-robot k8s-ci-robot added the needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Nov 24, 2023
@k8s-ci-robot
Copy link
Contributor

There are no sig labels on this issue. Please add an appropriate label by using one of the following commands:

  • /sig <group-name>
  • /wg <group-name>
  • /committee <group-name>

Please see the group list for a listing of the SIGs, working groups, and committees available.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@aojea
Copy link
Member Author

aojea commented Nov 24, 2023

/kind flake
/area prow

@k8s-ci-robot k8s-ci-robot added kind/flake Categorizes issue or PR as related to a flaky test. area/prow Issues or PRs related to prow labels Nov 24, 2023
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 22, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle rotten
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Mar 23, 2024
@alculquicondor
Copy link
Member

alculquicondor commented Apr 3, 2024 •
edited

Also observed in #32339: https://prow.k8s.io/view/gs/kubernetes-jenkins/pr-logs/pull/test-infra/32339/pull-test-infra-unit-test/1775523580885340160

@alculquicondor
Copy link
Member

@BenTheElder are you familiar with this error?
It seems to be flaking a lot now... or something is wrong with #32339, but I don't see it.

@BenTheElder
Copy link
Member

No, I haven't worked very actively on prow for many years now.
/remove-lifecycle rotten

Unfortunately not many people do. We can ask in the slack.

@k8s-ci-robot k8s-ci-robot removed the lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. label Apr 4, 2024
@MadhavJivrajani
Copy link
Contributor

/assign

@MadhavJivrajani MadhavJivrajani linked a pull request Apr 5, 2024 that will close this issue
Open
@MadhavJivrajani
Copy link
Contributor

Not an expert in prow, but trying to deflake here: #32384

@danilo-gemoli danilo-gemoli linked a pull request Apr 5, 2024 that will close this issue
Open
@danilo-gemoli
Copy link
Contributor

@MadhavJivrajani I haven't realized we were working on the same issue: #32385.
I've refactored the test out, hopefully we won't hit the (same?) race condition again.

@danilo-gemoli danilo-gemoli linked a pull request Apr 16, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MadhavJivrajani MadhavJivrajani

Labels
area/prow Issues or PRs related to prow kind/flake Categorizes issue or PR as related to a flaky test. needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one.
Projects
None yet
Milestone
No milestone
7 participants
@BenTheElder @alculquicondor @aojea @MadhavJivrajani @danilo-gemoli @k8s-ci-robot @k8s-triage-robot