add job to test packages with rpmlint #3589
Conversation
k8s-ci-robot
added
release-note
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: cpanato The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
k8s-ci-robot
added
needs-priority
approved
k8s-ci-robot
added
size/L
|
CI is not happy unfortunately: |
|
cc @xmudrii |
|
@xmudrii, can you please look at this PR when you have some time? Thanks! |
|
@cpanato It's on my TODO list, will try to get back to you as soon as possible. :) |
|
|
||
| for dir_name in ${dir_names}; do | ||
| echo "Processing Package: ${dir_name}" | ||
| krel obs specs --spec-only --package="${dir_name}" --template-dir="${dir_path}" |
There was a problem hiding this comment.
krel cannot auto-determine the version for cri-tools, at least at the moment. When building specs for the cri-tools package, you have to manually specify the version using the --version` flag.
There was a problem hiding this comment.
@cpanato Let me take a look today if we can somehow automatically determine the version.
| for dir_name in ${dir_names}; do | ||
| echo "Processing Package: ${dir_name}" | ||
| krel obs specs --spec-only --package="${dir_name}" --template-dir="${dir_path}" | ||
| rpmlint "${dir_name}".spec -r "${dir_name}".rpmlintrc -v |
There was a problem hiding this comment.
Do we have rpmlint in the image used by this job yet?
There was a problem hiding this comment.
yes we have in the image
| rpmlint "${dir_name}".spec -r "${dir_name}".rpmlintrc -v | ||
| done | ||
| else | ||
| echo "Directory ${dir_path} does not exist." |
There was a problem hiding this comment.
This should eventually exit with a non-zero status.
Signed-off-by: cpanato <ctadeu@gmail.com>
|
@cpanato: The following test failed, say
Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here. |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Which issue(s) this PR fixes:
Fixes #3166
Special notes for your reviewer:
Does this PR introduce a user-facing change?