Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go.mod: Update github.com/google/go-github to v48.2.0 #2840

Merged
merged 1 commit into from
Jan 3, 2023
Merged

go.mod: Update github.com/google/go-github to v48.2.0 #2840

merged 1 commit into from
Jan 3, 2023

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Jan 3, 2023

What type of PR is this?

/kind cleanup
/kind feature

What this PR does / why we need it:

  • go.mod: Update github.com/google/go-github to v48.2.0

similar we did here: kubernetes-sigs/release-sdk#147

/assign @xmudrii @saschagrunert @justaugustus @Verolop

Which issue(s) this PR fixes:

None

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/feature Categorizes issue or PR as related to a new feature. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority labels Jan 3, 2023
@k8s-ci-robot k8s-ci-robot added area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. approved Indicates a PR has been approved by an approver from all required OWNERS files. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 3, 2023
@cpanato
go.mod: Update github.com/google/go-github to v48.2.0
1259605 
Signed-off-by: cpanato <ctadeu@gmail.com>
@k8s-ci-robot k8s-ci-robot added size/M Denotes a PR that changes 30-99 lines, ignoring generated files. and removed size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Jan 3, 2023
@cpanato
Copy link
Member Author

cpanato commented Jan 3, 2023

/assign @xmudrii @saschagrunert @justaugustus @Verolop

@cpanato
Copy link
Member Author

cpanato commented Jan 3, 2023

/test pull-release-integration-test

@cpanato
Copy link
Member Author

cpanato commented Jan 3, 2023

/test pull-release-test

xmudrii
xmudrii approved these changes Jan 3, 2023
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jan 3, 2023
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, xmudrii

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 64ceb0e into kubernetes:master Jan 3, 2023
@cpanato cpanato deleted the update-go-github branch January 3, 2023 13:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xmudrii xmudrii xmudrii approved these changes

@cici37 cici37 Awaiting requested review from cici37

@jimangel jimangel Awaiting requested review from jimangel

Assignees

@justaugustus justaugustus

@saschagrunert saschagrunert

@Verolop Verolop

@xmudrii xmudrii

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note-none Denotes a PR that doesn't merit a release note. sig/release Categorizes an issue or PR as relevant to SIG Release. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@cpanato @k8s-ci-robot @xmudrii @justaugustus @saschagrunert @Verolop