Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[go] Build go1.16.6 and go1.15.14 images #2162

Merged
merged 1 commit into from
Jul 13, 2021

Conversation

mengjiao-liu
Copy link
Member

What type of PR is this?

/kind feature
/area dependency release-eng/security

What this PR does / why we need it:

Tracking issue: #2157

  • [go] go1.16.6 and go1.15.14 updates
  • kube-cross: Build v1.16.6-1 and v1.15.14-1 images
  • go-runner: Build v2.3.1-go1.16.6-buster.0 and v2.3.1-go1.15.14-buster.0
  • releng-ci: build iamge for go1.16.6 and go1.15.14
  • kubepkg/packages-deb: update base image to go1.16.6

Which issue(s) this PR fixes:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

- [go] go1.16.6 and go1.15.14 updates
- kube-cross: Build v1.16.6-1 and v1.15.14-1 images
- go-runner: Build v2.3.1-go1.16.6-buster.0 and v2.3.1-go1.15.14-buster.0
- releng-ci: build iamge for go1.16.6 and go1.15.14
- kubepkg/packages-deb: update base image to go1.16.6

/assign @thejoycekung @saschagrunert @puerco @justaugustus
cc @kubernetes/release-engineering

@k8s-ci-robot k8s-ci-robot added the release-note Denotes a PR that will be considered when it comes time to generate release notes. label Jul 13, 2021
@k8s-ci-robot k8s-ci-robot added kind/feature Categorizes issue or PR as related to a new feature. area/dependency Issues or PRs related to dependency changes cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/release-eng/security Issues or PRs related to release engineering security needs-priority area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. labels Jul 13, 2021
@k8s-ci-robot k8s-ci-robot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Jul 13, 2021
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your contribution! Please make sure that you also change the following files to fix the presubmit failure:

  • images/releng/k8s-ci-builder/Makefile
  • images/releng/k8s-ci-builder/Dockerfile
  • images/releng/k8s-ci-builder/variants.yaml

@xmudrii
Copy link
Member

xmudrii commented Jul 13, 2021

/test pull-release-image-go-runner

@mengjiao-liu
Copy link
Member Author

Thank you for your contribution! Please make sure that you also change the following files to fix the presubmit failure:

  • images/releng/k8s-ci-builder/Makefile
  • images/releng/k8s-ci-builder/Dockerfile
  • images/releng/k8s-ci-builder/variants.yaml

These files should be updated after updating kubernetes/kubernetes.

The previous error was probably because I accidentally changed the version of the section under dependents.yaml:

 - name: "golang: after kubernetes/kubernetes update"
    version: 1.16.5
 - name: "golang: after kubernetes/kubernetes update (for previous release branches)"
    version: 1.15.13

It has been modified back to the original version.

Copy link
Member

@justaugustus justaugustus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @mengjiao-liu!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jul 13, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: justaugustus, mengjiao-liu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 13, 2021
@k8s-ci-robot k8s-ci-robot merged commit 1550f42 into kubernetes:master Jul 13, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Jul 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/dependency Issues or PRs related to dependency changes area/release-eng/security Issues or PRs related to release engineering security area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/feature Categorizes issue or PR as related to a new feature. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants