Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bash: use k8s-release-dev for CI builds #2158

Merged
merged 1 commit into from
Jul 13, 2021

Conversation

spiffxp
Copy link
Member

@spiffxp spiffxp commented Jul 9, 2021

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Default to community-owned gs://k8s-release-dev instead of
google.com-owned gs://kubernetes-release-dev for reading and
writing CI builds

Specifically we're modifying the default value for two bash scripts:

  • push-build.sh
  • packages/deb/jenkins.sh

Which issue(s) this PR fixes:

This doesn't fix, but is part of:

Special notes for your reviewer:

/hold
I would prefer to see kubernetes/test-infra#22840
merge first, and be able to remove /hold once I'm satisfied and
available to watch over any impact

That updates the deprecated --scenario=kubernetes_build jobs such that
they'll end up explicitly passing --bucket=kubernetes-release-dev to
push-build.sh

Does this PR introduce a user-facing change?

push-build.sh defaults to k8s-release-dev instead of
kubernetes-release-dev (https://github.com/kubernetes/k8s.io/issues/846)

@k8s-ci-robot k8s-ci-robot added do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. release-note Denotes a PR that will be considered when it comes time to generate release notes. do-not-merge/blocked-paths Indicates that a PR should not merge because it touches files in blocked paths. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. labels Jul 9, 2021
@k8s-ci-robot
Copy link
Contributor

@spiffxp: Adding label: do-not-merge/blocked-paths because PR changes a protected file.

Reasons for blocking this PR:

[Changes to push-build.sh will immediately affect the Kubernetes CI. This PR must be explicitly approved by SIG Release repo admins.]

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority labels Jul 9, 2021
@k8s-ci-robot k8s-ci-robot added area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jul 9, 2021
@spiffxp
Copy link
Member Author

spiffxp commented Jul 9, 2021

/uncc @sethmccombs @mkorbi
/cc @cpanato @puerco @justaugustus @saschagrunert @xmudrii
FYI @kubernetes/release-managers

@k8s-ci-robot k8s-ci-robot requested review from cpanato, justaugustus, puerco, saschagrunert and xmudrii and removed request for sethmccombs and mkorbi July 9, 2021 20:17
@justaugustus justaugustus removed the do-not-merge/blocked-paths Indicates that a PR should not merge because it touches files in blocked paths. label Jul 9, 2021
@justaugustus
Copy link
Member

/hold
I would prefer to see kubernetes/test-infra#22840
merge first, and be able to remove /hold once I'm satisfied and
available to watch over any impact

Echoing Aaron with an explicit hold for monitoring jobs following the merge of kubernetes/test-infra#22840.

FYI @kubernetes/release-engineering @kubernetes/ci-signal @kubernetes/release-team
/lgtm
/approve

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jul 9, 2021
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

Copy link
Member

@cpanato cpanato left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, justaugustus, saschagrunert, spiffxp

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [cpanato,justaugustus,saschagrunert]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@spiffxp
Copy link
Member Author

spiffxp commented Jul 13, 2021

/hold cancel
Now that kubernetes/kubernetes#103647 is out of the way, I'm ready to watch these changes go in

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 13, 2021
@spiffxp
Copy link
Member Author

spiffxp commented Jul 13, 2021

/retest
Neat, a GitHub API rate limit

changelog_test.go:236: 
        	Error Trace:	changelog_test.go:236
        	Error:      	Expected nil, but got: get latest GitHub tags: unable to retrieve GitHub tags: GET https://api.github.com/repos/kubernetes/kubernetes/tags?page=10&per_page=50: 403 API rate limit of 60 still exceeded until 2021-07-13 22:52:48 +0000 UTC, not making remote request. [rate reset in 20m55s]
        	Test:       	TestNewRCRelease

@k8s-ci-robot k8s-ci-robot merged commit 1bf4791 into kubernetes:master Jul 13, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Jul 13, 2021
@liggitt
Copy link
Member

liggitt commented Jul 14, 2021

https://prow.k8s.io/view/gs/kubernetes-jenkins/logs/ci-kubernetes-e2e-gce-stable1-beta-upgrade-master started failing on the extract step ~4 days ago with this error:

Failed to set release from https://storage.googleapis.com/k8s-release-dev/ci/k8s-beta.txt (Unexpected HTTP status code: 404)

Are there changes required in kubernetes/kubernetes or do we need to backfill marker files to this bucket?

@liggitt
Copy link
Member

liggitt commented Jul 14, 2021

tracking upgrade test failure in kubernetes/kubernetes#103697

@spiffxp spiffxp deleted the use-k8s-release-dev branch July 19, 2021 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants