Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update go-git to v5.4.2 to fix repo cloning bug #2104

Merged
merged 1 commit into from
Jun 2, 2021

Conversation

puerco
Copy link
Member

@puerco puerco commented Jun 2, 2021

What type of PR is this?

/kind bug

What this PR does / why we need it:

This PR bumps the go-git package to version v5.4.2 which fixes a bug that was preventing us from cloning kubernetes/kubernetes

/priority critical-urgent
/milestone v1.22

Signed-off-by: Adolfo García Veytia (Puerco) adolfo.garcia@uservers.net

Which issue(s) this PR fixes:

Fixes #2094

Special notes for your reviewer:

The go-git team has disabled the feature that caused the bug: go-git/go-git#326

I have confirmed the release process runs again from my branch: https://console.cloud.google.com/cloud-build/builds;region=global/951c177e-eaea-4d0f-a943-2849b78ffd3d?project=kubernetes-release-test

Step #3: INFO[2021-06-02T14:12:58Z] Preparing workspace for staging in /workspace/src/k8s.io/kubernetes 
Step #3: INFO[2021-06-02T14:12:58Z] Cloning repository to /workspace/src/k8s.io/kubernetes 
Step #3: INFO[2021-06-02T14:16:33Z] Tagging repository                            step=6/9
Step #3: INFO[2021-06-02T14:16:33Z] Preparing version v1.22.0-alpha.3            
Step #3: INFO[2021-06-02T14:16:33Z] Checking out branch master                   
Step #3: INFO[2021-06-02T14:16:33Z] Current branch is master                     
Step #3: INFO[2021-06-02T14:16:33Z] Detaching HEAD at commit 1795a98eebe58f to create tag v1.22.0-alpha.3 

Does this PR introduce a user-facing change?

Update `go-git` to v5.4.2 to fix a bug that prevented the release process to clone repositories

Signed-off-by: Adolfo García Veytia (Puerco) <adolfo.garcia@uservers.net>
@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. labels Jun 2, 2021
@k8s-ci-robot k8s-ci-robot added this to the v1.22 milestone Jun 2, 2021
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Jun 2, 2021
@k8s-ci-robot k8s-ci-robot added area/release-eng Issues or PRs related to the Release Engineering subproject sig/release Categorizes an issue or PR as relevant to SIG Release. approved Indicates a PR has been approved by an approver from all required OWNERS files. labels Jun 2, 2021
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: puerco, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:
  • OWNERS [puerco,saschagrunert]

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Jun 2, 2021
@k8s-ci-robot k8s-ci-robot merged commit 847167a into kubernetes:master Jun 2, 2021
@puerco puerco deleted the go-git-update branch June 2, 2021 14:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. lgtm "Looks good to me", indicates that a PR is ready to be merged. priority/critical-urgent Highest priority. Must be actively worked on as someone's top priority right now. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Release process breaks when cloning kubernetes/kubernetes
3 participants