Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

dependencies/cobra: update cobra to v0.0.7 #1237

Merged
merged 2 commits into from Apr 15, 2020
Merged

dependencies/cobra: update cobra to v0.0.7 #1237

merged 2 commits into from Apr 15, 2020

Conversation

cpanato
Copy link
Member

@cpanato cpanato commented Apr 8, 2020 •
edited

What type of PR is this?

/kind cleanup

What this PR does / why we need it:

Update cobra dependency to v0.0.7 which is the latest available and has the following changes:

  • Bug fix to restore previous exit behavior when a command is not runnable

Which issue(s) this PR fixes:

Fixes #

Special notes for your reviewer:

Does this PR introduce a user-facing change?

dependencies/cobra: update cobra to v0.0.7

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. needs-priority size/S Denotes a PR that changes 10-29 lines, ignoring generated files. labels Apr 8, 2020
@k8s-ci-robot k8s-ci-robot added the sig/release Categorizes an issue or PR as relevant to SIG Release. label Apr 8, 2020
saschagrunert
saschagrunert approved these changes Apr 8, 2020
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 8, 2020
hasheddan
hasheddan suggested changes Apr 8, 2020
View reviewed changes
Copy link
Contributor

@hasheddan hasheddan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@cpanato I think you want "dependencies/cobra: update cobra to v0.0.7" in title, commit, and release note here :)

@hasheddan
Copy link
Contributor

@cpanato I think failing test is related to this: spf13/cobra#1056

@cpanato cpanato changed the title dependencies/cobra: update logrus to v0.0.7 dependencies/cobra: update cobra to v0.0.7 Apr 8, 2020
@cpanato
dependencies/cobra: update cobra to v0.0.7
d67b669 
Noticeable changes in this release:
- Bug fix to restore previous exit behavior when a command is not runnable
@k8s-ci-robot k8s-ci-robot removed the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 8, 2020
@cpanato
Copy link
Member Author

cpanato commented Apr 8, 2020

thanks @hasheddan 🤦‍♂

@cpanato
Copy link
Member Author

cpanato commented Apr 8, 2020

@hasheddan I'm going to check that later, thanks!! :D

@cpanato
Copy link
Member Author

cpanato commented Apr 8, 2020

@hasheddan @saschagrunert update the tests to reflect the change in the lib

saschagrunert
saschagrunert approved these changes Apr 8, 2020
View reviewed changes
Copy link
Member

@saschagrunert saschagrunert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label Apr 8, 2020
hasheddan
hasheddan approved these changes Apr 8, 2020
View reviewed changes
Copy link
Contributor

@hasheddan hasheddan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@justaugustus
Copy link
Member

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: cpanato, hasheddan, justaugustus, saschagrunert

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Apr 15, 2020
@justaugustus
Copy link
Member

/retest

@k8s-ci-robot k8s-ci-robot merged commit 191ddd0 into kubernetes:master Apr 15, 2020
@k8s-ci-robot k8s-ci-robot added this to the v1.19 milestone Apr 15, 2020
@cpanato cpanato deleted the update-cobra branch April 15, 2020 06:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saschagrunert saschagrunert saschagrunert approved these changes

@hasheddan hasheddan hasheddan approved these changes

Assignees

@justaugustus justaugustus

@saschagrunert saschagrunert

@hasheddan hasheddan

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/release-eng Issues or PRs related to the Release Engineering subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/cleanup Categorizes issue or PR as related to cleaning up code, process, or technical debt. lgtm "Looks good to me", indicates that a PR is ready to be merged. needs-priority release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/release Categorizes an issue or PR as relevant to SIG Release. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
v1.19
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@cpanato @hasheddan @justaugustus @k8s-ci-robot @saschagrunert