Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync CAPZ admins with Azure provider project #4937

Merged
merged 1 commit into from May 14, 2024
Merged

Sync CAPZ admins with Azure provider project #4937

merged 1 commit into from May 14, 2024

Conversation

mboersma
Copy link
Contributor

@mboersma mboersma commented May 8, 2024

Syncs up with recent changes to https://github.com/kubernetes-sigs/cluster-api-provider-azure/blob/main/OWNERS_ALIASES

Specifically, adds @Jont828 and @willie-yao to admins/maintainers.

/cc @jackfrancis @Jont828 @nojnhuh

@k8s-ci-robot k8s-ci-robot added area/github-management Issues or PRs related to GitHub Management subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels May 8, 2024
nojnhuh
nojnhuh approved these changes May 8, 2024
View reviewed changes
Copy link
Contributor

@nojnhuh nojnhuh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 8, 2024
@mboersma
Copy link
Contributor Author

mboersma commented May 8, 2024

/assign @neolit123

@mboersma
Copy link
Contributor Author

/assign @fabriziopandini

@mboersma
Copy link
Contributor Author

/assign @vincepri

@mboersma
Copy link
Contributor Author

/assign @justinsb

@fabriziopandini
Copy link
Member

Yay!
/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: fabriziopandini, mboersma, nojnhuh

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 14, 2024
@k8s-ci-robot k8s-ci-robot merged commit 2f03cb4 into kubernetes:main May 14, 2024
4 checks passed
@mboersma mboersma deleted the sync-capz-owners branch May 14, 2024 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nojnhuh nojnhuh nojnhuh approved these changes

@jackfrancis jackfrancis Awaiting requested review from jackfrancis

@Jont828 Jont828 Awaiting requested review from Jont828

Assignees

@justinsb justinsb

@neolit123 neolit123

@vincepri vincepri

@fabriziopandini fabriziopandini

@nojnhuh nojnhuh

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/github-management Issues or PRs related to GitHub Management subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. sig/cluster-lifecycle Categorizes an issue or PR as relevant to SIG Cluster Lifecycle. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@mboersma @fabriziopandini @k8s-ci-robot @nojnhuh @justinsb @neolit123 @vincepri