Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add to maintainers list for pdcsi and filestorecsi repos #4799

Merged
merged 1 commit into from May 13, 2024
Merged

Add to maintainers list for pdcsi and filestorecsi repos #4799

merged 1 commit into from May 13, 2024

Conversation

Sneha-at
Copy link
Contributor

@Sneha-at Sneha-at commented Feb 29, 2024 •
edited

This add write permissions for @Sneha-at to gcp-compute-persistent-disk-csi-driver and gcp-filestore-csi-driver repositories.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/github-management Issues or PRs related to GitHub Management subproject labels Feb 29, 2024
@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 29, 2024
@Sneha-at
Copy link
Contributor Author

/cc @amacaskill
/cc @pwschuurman

dipesh-rawat
dipesh-rawat reviewed Mar 1, 2024
View reviewed changes
config/kubernetes-sigs/org.yaml Outdated
Comment on lines 1006 to 1044
- songjiaxun
- sunnylovestiramisu
- tyuchn
- sneha-at
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR checks failed because the list isn't sorted (reference link). Could you please make sure the members list is sorted after adding the new entry?

Suggested change
- songjiaxun
- sunnylovestiramisu
- tyuchn
- sneha-at
- sneha-at
- songjiaxun
- sunnylovestiramisu
- tyuchn

dipesh-rawat
dipesh-rawat reviewed Mar 1, 2024
View reviewed changes
config/kubernetes-sigs/org.yaml Outdated
Comment on lines 1036 to 1076
- songjiaxun
- sunnylovestiramisu
- tyuchn
- sneha-at
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This list will require sorting as well.

Suggested change
- songjiaxun
- sunnylovestiramisu
- tyuchn
- sneha-at
- sneha-at
- songjiaxun
- sunnylovestiramisu
- tyuchn

@Priyankasaggu11929
Copy link
Member

/hold

for review from https://github.com/orgs/kubernetes-sigs/teams/gcp-compute-persistent-disk-csi-driver-admins

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Mar 1, 2024
@Priyankasaggu11929
Copy link
Member

@Sneha-at, could you please update the commit message, to describe the GH team repo changes

@Priyankasaggu11929
Copy link
Member

@Sneha-at, Just a friendly ping for the requested changes, thanks.

@Sneha-at Sneha-at force-pushed the add_sneha-at_to_maintainers branch 2 times, most recently from 19f5e27 to 97e09c0 Compare May 13, 2024 14:59
@Priyankasaggu11929
Copy link
Member

@mattcary, could you please review/approve this PR? Thanks!

@Sneha-at
Copy link
Contributor Author

/retest-required

@Sneha-at Sneha-at force-pushed the add_sneha-at_to_maintainers branch from 97e09c0 to b557473 Compare May 13, 2024 15:11
@Sneha-at
Copy link
Contributor Author

/retest-required

@mattcary
Copy link
Contributor

/lgtm
/approve

Welcome, Sneha!

@k8s-ci-robot k8s-ci-robot added the lgtm "Looks good to me", indicates that a PR is ready to be merged. label May 13, 2024
@Priyankasaggu11929
Copy link
Member

/approve

/unhold

@k8s-ci-robot k8s-ci-robot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label May 13, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: mattcary, Priyankasaggu11929, Sneha-at

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label May 13, 2024
@k8s-ci-robot k8s-ci-robot merged commit b954985 into kubernetes:main May 13, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dipesh-rawat dipesh-rawat dipesh-rawat left review comments

@jasonbraganza jasonbraganza Awaiting requested review from jasonbraganza

@Priyankasaggu11929 Priyankasaggu11929 Awaiting requested review from Priyankasaggu11929

@amacaskill amacaskill Awaiting requested review from amacaskill

@pwschuurman pwschuurman Awaiting requested review from pwschuurman

Assignees

@mattcary mattcary

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/github-management Issues or PRs related to GitHub Management subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@Sneha-at @Priyankasaggu11929 @mattcary @k8s-ci-robot @dipesh-rawat