Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mehabhalodiya to release-engineering group #4797

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mehabhalodiya
Copy link

Signed-off-by: mehabhalodiya <mehabhalodiya@gmail.com>
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. area/github-management Issues or PRs related to GitHub Management subproject labels Feb 28, 2024
@k8s-ci-robot k8s-ci-robot added the sig/release Categorizes an issue or PR as relevant to SIG Release. label Feb 28, 2024
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: mehabhalodiya
Once this PR has been reviewed and has the lgtm label, please assign jeremyrickard for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. label Feb 28, 2024
@mehabhalodiya
Copy link
Author

/retest

@k8s-ci-robot
Copy link
Contributor

@mehabhalodiya: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-org-test-all 049ff1a link true /test pull-org-test-all

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

Comment on lines +302 to 304
- marosset # 1.30 RT Branch Manager
- mehabhalodiya # 1.30 RT Branch Manager Shadow
- meganwolf0 # 1.30 Enhancements Shadow
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @mehabhalodiya, Just a heads up – the Prow job (here) is failing due to an unsorted entry.

--- FAIL: TestAllOrgs (0.06s)
config_test.go:268: The team release-team in org Kubernetes has an unsorted list of members.

Sorting the list should get us past the check.

Suggested change
- marosset # 1.30 RT Branch Manager
- mehabhalodiya # 1.30 RT Branch Manager Shadow
- meganwolf0 # 1.30 Enhancements Shadow
- marosset # 1.30 RT Branch Manager
- meganwolf0 # 1.30 Enhancements Shadow
- mehabhalodiya # 1.30 RT Branch Manager Shadow

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/github-management Issues or PRs related to GitHub Management subproject cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. sig/release Categorizes an issue or PR as relevant to SIG Release. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants