WIP: Use pooling support that's being added to cheggaaa/pb/v3 to fix download progress bar #12240

yayaha · 2021-08-12T01:31:48Z

This PR is built upon a combination of cheggaaa/pb#188 and #11673 (thanks @cheggaaa and @afbjorklund). More specifically, below are some notable changes:

Both image.go and progressbar.go will be using a single DefaultProgressTracker defined in progressbard.go.
Set the total size of progress bars in image.go early. Otherwise, the total size is updated only after the download starts, which causes an incorrectly sized progress bar.

Output during download:

Downloading Kubernetes v1.21.3 preload ...
    > preloaded-images-k8s-v11-v1...: 89.70 MiB / 481.44 MiB [-->___________] 18.63% 4.95 MiB p/s ETA 1m19s
    > gcr.io/k8s-minikube/kicbase: 35.00 MiB / 361.09 MiB [->________________] 9.69% 1.63 MiB p/s ETA 3m19s

Output after download completes:

Downloading Kubernetes v1.21.3 preload ...
    > preloaded-images-k8s-v11-v1...: 481.44 MiB / 481.44 MiB [----------------] 100.00% 4.33 MiB p/s 1m51s
    > gcr.io/k8s-minikube/kicbase: 361.09 MiB / 361.09 MiB [-------------------] 100.00% 3.25 MiB p/s 1m51s

github.com/cheggaaa/pb/v3

k8s-ci-robot · 2021-08-12T01:31:56Z

Welcome @yayaha!

It looks like this is your first PR to kubernetes/minikube 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/minikube has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

k8s-ci-robot · 2021-08-12T01:31:56Z

Hi @yayaha. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

k8s-ci-robot · 2021-08-12T01:31:57Z

Thanks for your pull request. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please follow instructions at https://git.k8s.io/community/CLA.md#the-contributor-license-agreement to sign the CLA.

It may take a couple minutes for the CLA signature to be fully registered; after that, please reply here with a new comment and we'll verify. Thanks.

If you've already signed a CLA, it's possible we don't have your GitHub username or you're using a different email address. Check your existing CLA data and verify that your email is set on your git commits.
If you signed the CLA as a corporation, please sign in with your organization's credentials at https://identity.linuxfoundation.org/projects/cncf to be authorized.
If you have done the above and are still having issues with the CLA being reported as unsigned, please log a ticket with the Linux Foundation Helpdesk: https://support.linuxfoundation.org/
Should you encounter any issues with the Linux Foundation Helpdesk, send a message to the backup e-mail support address at: login-issues@jira.linuxfoundation.org

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

minikube-bot · 2021-08-12T01:32:04Z

Can one of the admins verify this patch?

yayaha · 2021-08-12T01:41:29Z

/assign @medyagh

medyagh · 2021-08-12T23:37:07Z

/ok-to-test

minikube-pr-bot · 2021-08-13T01:57:43Z

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12240) |
+----------------+----------+---------------------+
| minikube start | 50.4s    | 51.2s               |
| enable ingress | 31.1s    | 32.2s               |
+----------------+----------+---------------------+

Times for minikube start: 56.4s 50.7s 46.7s 48.8s 49.6s
Times for minikube (PR 12240) start: 48.5s 56.9s 48.1s 51.0s 51.4s

Times for minikube ingress: 30.9s 30.3s 30.8s 31.8s 31.8s
Times for minikube (PR 12240) ingress: 32.3s 30.8s 34.4s 32.3s 31.3s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12240) |
+----------------+----------+---------------------+
| minikube start | 23.1s    | 22.6s               |
| enable ingress | 26.8s    | 26.6s               |
+----------------+----------+---------------------+

Times for minikube start: 23.4s 23.3s 23.6s 22.2s 23.1s
Times for minikube (PR 12240) start: 22.6s 22.2s 22.2s 23.5s 22.6s

Times for minikube ingress: 27.0s 26.5s 26.5s 26.5s 27.5s
Times for minikube (PR 12240) ingress: 25.5s 26.5s 27.5s 26.6s 27.0s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12240) |
+----------------+----------+---------------------+
| minikube start | 41.2s    | 44.2s               |
| enable ingress |          |                     |
+----------------+----------+---------------------+

Times for minikube start: 31.7s 43.4s 43.8s 43.7s 43.5s
Times for minikube (PR 12240) start: 44.7s 43.9s 43.7s 44.1s 44.8s

minikube-pr-bot · 2021-08-13T08:57:47Z

These are the flake rates of all failed tests.

Environment	Failed Tests	Flake Rate (%)
Docker_Linux_containerd_arm64	TestDownloadOnlyKic (gopogh)	n/a
Docker_Linux_crio_arm64	TestDownloadOnlyKic (gopogh)	n/a
Docker_Linux_docker_arm64	TestDownloadOnlyKic (gopogh)	n/a
Docker_Linux_containerd	TestDownloadOnlyKic (gopogh)	0.00 (chart)
Docker_Linux_crio	TestDownloadOnlyKic (gopogh)	0.00 (chart)
Docker_Linux	TestDownloadOnlyKic (gopogh)	0.00 (chart)
Docker_Windows	TestDownloadOnly/DeleteAll (gopogh)	0.00 (chart)
Docker_Windows	TestDownloadOnly/DeleteAlwaysSucceeds (gopogh)	0.00 (chart)
Docker_Windows	TestDownloadOnlyKic (gopogh)	0.00 (chart)
Docker_Windows	TestDownloadOnly/v1.14.0/json-events (gopogh)	0.00 (chart)
Docker_Windows	TestDownloadOnly/v1.21.3/json-events (gopogh)	0.00 (chart)
Docker_Windows	TestDownloadOnly/v1.21.3/kubectl (gopogh)	0.00 (chart)
Docker_Windows	TestDownloadOnly/v1.21.3/preload-exists (gopogh)	0.00 (chart)
Docker_Windows	TestDownloadOnly/v1.22.0-rc.0/json-events (gopogh)	0.00 (chart)
Docker_Windows	TestDownloadOnly/v1.22.0-rc.0/kubectl (gopogh)	0.00 (chart)
Docker_Windows	TestDownloadOnly/v1.22.0-rc.0/preload-exists (gopogh)	0.00 (chart)
Hyperkit_macOS	TestAddons/parallel/Ingress (gopogh)	1.64 (chart)
Hyperkit_macOS	TestMultiNode/serial/ProfileList (gopogh)	1.64 (chart)
Hyperkit_macOS	TestMultiNode/serial/StopNode (gopogh)	1.64 (chart)
KVM_Linux_crio	TestStartStop/group/no-preload/serial/DeployApp (gopogh)	2.04 (chart)
KVM_Linux_crio	TestStartStop/group/no-preload/serial/FirstStart (gopogh)	2.04 (chart)
Hyperkit_macOS	TestPreload (gopogh)	2.46 (chart)
Hyperkit_macOS	TestFunctional/parallel/BuildImage (gopogh)	3.31 (chart)
Hyperkit_macOS	TestFunctional/parallel/MySQL (gopogh)	3.31 (chart)
Hyperkit_macOS	TestMultiNode/serial/RestartKeepsNodes (gopogh)	5.17 (chart)
Hyperkit_macOS	TestMultiNode/serial/RestartMultiNode (gopogh)	5.17 (chart)
Hyperkit_macOS	TestMultiNode/serial/DeleteNode (gopogh)	6.03 (chart)
Hyperkit_macOS	TestFunctional/parallel/TunnelCmd/serial/AccessDirect (gopogh)	7.44 (chart)
Hyperkit_macOS	TestFunctional/parallel/TunnelCmd/serial/AccessThroughDNS (gopogh)	7.44 (chart)
Hyperkit_macOS	TestFunctional/parallel/PersistentVolumeClaim (gopogh)	8.26 (chart)
More tests...	Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

yayaha · 2021-08-13T19:15:00Z

Need to look into the failing tests.

yayaha · 2021-08-19T23:59:16Z

/retest

medyagh · 2021-08-23T22:18:09Z

@yayaha have u tried this on windows ? is it okay there?

k8s-ci-robot · 2021-08-25T22:03:21Z

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: yayaha
To complete the pull request process, please ask for approval from medyagh after the PR has been reviewed.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

minikube-pr-bot · 2021-08-25T22:54:22Z

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12240) |
+----------------+----------+---------------------+
| minikube start | 54.7s    | 53.9s               |
| enable ingress | 33.3s    | 33.8s               |
+----------------+----------+---------------------+

Times for minikube start: 56.8s 55.4s 54.9s 54.1s 52.6s
Times for minikube (PR 12240) start: 52.2s 54.7s 54.4s 53.4s 54.5s

Times for minikube (PR 12240) ingress: 33.5s 34.4s 33.0s 33.0s 35.3s
Times for minikube ingress: 33.9s 31.8s 33.6s 33.9s 33.4s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12240) |
+----------------+----------+---------------------+
| minikube start | 23.4s    | 22.7s               |
| enable ingress | 28.6s    | 30.6s               |
+----------------+----------+---------------------+

Times for minikube start: 24.1s 22.7s 22.9s 23.2s 24.3s
Times for minikube (PR 12240) start: 22.9s 22.5s 22.4s 22.7s 23.0s

Times for minikube ingress: 27.5s 26.5s 35.5s 26.5s 27.0s
Times for minikube (PR 12240) ingress: 35.0s 28.0s 35.5s 27.0s 27.5s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12240) |
+----------------+----------+---------------------+
| minikube start | 38.4s    | 44.3s               |
| enable ingress |          |                     |
+----------------+----------+---------------------+

Times for minikube start: 29.4s 44.2s 44.0s 43.9s 30.6s
Times for minikube (PR 12240) start: 42.8s 43.9s 44.3s 45.6s 44.7s

k8s-ci-robot · 2021-08-26T00:19:30Z

@yayaha: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name	Commit	Details	Rerun command
pull-minikube-build	`615df84`	link	`/test pull-minikube-build`

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

minikube-pr-bot · 2021-08-26T01:44:57Z

These are the flake rates of all failed tests.

Environment	Failed Tests	Flake Rate (%)
Docker_Linux_containerd_arm64	TestDownloadOnlyKic (gopogh)	n/a
Docker_Linux_crio_arm64	TestDownloadOnlyKic (gopogh)	n/a
Docker_Linux_containerd	TestDownloadOnlyKic (gopogh)	0.00 (chart)
Docker_Linux_crio	TestDownloadOnlyKic (gopogh)	0.00 (chart)
Docker_Linux	TestDownloadOnlyKic (gopogh)	0.00 (chart)
Docker_macOS	TestDownloadOnly/DeleteAll (gopogh)	0.00 (chart)
Docker_macOS	TestDownloadOnly/DeleteAlwaysSucceeds (gopogh)	0.00 (chart)
Docker_macOS	TestDownloadOnly/v1.14.0/json-events (gopogh)	0.00 (chart)
Docker_macOS	TestDownloadOnly/v1.22.1/json-events (gopogh)	0.00 (chart)
Docker_macOS	TestDownloadOnly/v1.22.1/kubectl (gopogh)	0.00 (chart)
Docker_macOS	TestDownloadOnly/v1.22.1/preload-exists (gopogh)	0.00 (chart)
Docker_macOS	TestDownloadOnly/v1.22.2-rc.0/json-events (gopogh)	0.00 (chart)
Docker_macOS	TestDownloadOnly/v1.22.2-rc.0/kubectl (gopogh)	0.00 (chart)
Docker_macOS	TestDownloadOnly/v1.22.2-rc.0/preload-exists (gopogh)	0.00 (chart)
Docker_Windows	TestDownloadOnly/DeleteAll (gopogh)	0.00 (chart)
Docker_Windows	TestDownloadOnly/DeleteAlwaysSucceeds (gopogh)	0.00 (chart)
Docker_Windows	TestDownloadOnlyKic (gopogh)	0.00 (chart)
Docker_Windows	TestDownloadOnly/v1.14.0/json-events (gopogh)	0.00 (chart)
Docker_Windows	TestDownloadOnly/v1.22.1/json-events (gopogh)	0.00 (chart)
Docker_Windows	TestDownloadOnly/v1.22.1/kubectl (gopogh)	0.00 (chart)
Docker_Windows	TestDownloadOnly/v1.22.1/preload-exists (gopogh)	0.00 (chart)
Docker_Windows	TestDownloadOnly/v1.22.2-rc.0/json-events (gopogh)	0.00 (chart)
Docker_Windows	TestDownloadOnly/v1.22.2-rc.0/kubectl (gopogh)	0.00 (chart)
Docker_Windows	TestDownloadOnly/v1.22.2-rc.0/preload-exists (gopogh)	0.00 (chart)
KVM_Linux_containerd	TestFunctional/parallel/SaveImage (gopogh)	0.00 (chart)
KVM_Linux	TestFunctional/parallel/SaveImage (gopogh)	0.00 (chart)
Docker_Windows	TestFunctional/parallel/LoadImageFromFile (gopogh)	0.77 (chart)
KVM_Linux	TestRunningBinaryUpgrade (gopogh)	1.33 (chart)
KVM_Linux	TestStoppedBinaryUpgrade/MinikubeLogs (gopogh)	2.01 (chart)
KVM_Linux	TestStoppedBinaryUpgrade/Upgrade (gopogh)	3.12 (chart)
More tests...	Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

k8s-ci-robot · 2021-11-09T22:42:43Z

@yayaha: PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

minikube-pr-bot · 2021-11-18T01:05:37Z

kvm2 driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12240) |
+----------------+----------+---------------------+
| minikube start | 48.4s    | 53.6s               |
| enable ingress | 32.7s    | 32.4s               |
+----------------+----------+---------------------+

Times for minikube start: 49.2s 49.2s 47.8s 48.2s 47.8s
Times for minikube (PR 12240) start: 55.1s 51.0s 55.2s 55.1s 51.5s

Times for minikube ingress: 31.9s 32.8s 33.3s 32.8s 32.9s
Times for minikube (PR 12240) ingress: 31.9s 33.3s 33.0s 30.8s 32.9s

docker driver with docker runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12240) |
+----------------+----------+---------------------+
| minikube start | 23.4s    | 26.6s               |
| enable ingress | 30.7s    | 29.2s               |
+----------------+----------+---------------------+

Times for minikube start: 23.7s 22.6s 24.1s 23.7s 22.7s
Times for minikube (PR 12240) start: 27.2s 25.9s 26.7s 27.1s 26.0s

Times for minikube ingress: 29.0s 28.5s 27.0s 34.0s 35.0s
Times for minikube (PR 12240) ingress: 29.0s 27.5s 30.0s 27.0s 32.5s

docker driver with containerd runtime

+----------------+----------+---------------------+
|    COMMAND     | MINIKUBE | MINIKUBE (PR 12240) |
+----------------+----------+---------------------+
| minikube start | 35.5s    | 48.4s               |
| enable ingress | 31.8s    | 27.7s               |
+----------------+----------+---------------------+

Times for minikube start: 31.1s 36.9s 37.4s 30.1s 42.0s
Times for minikube (PR 12240) start: 47.7s 37.7s 55.9s 50.7s 50.1s

Times for minikube (PR 12240) ingress: 28.0s 30.0s 28.4s 19.5s 32.5s
Times for minikube ingress: 38.5s 24.7s 34.5s 28.0s 33.5s

minikube-pr-bot · 2021-11-18T02:30:02Z

These are the flake rates of all failed tests.

Environment	Failed Tests	Flake Rate (%)
Docker_Linux_containerd_arm64	TestDownloadOnly/v1.22.1/json-events (gopogh)	n/a
Docker_Linux_containerd_arm64	TestDownloadOnly/v1.22.1/preload-exists (gopogh)	n/a
Docker_Linux_containerd_arm64	TestDownloadOnly/v1.22.2-rc.0/json-events (gopogh)	n/a
Docker_Linux_containerd_arm64	TestDownloadOnly/v1.22.2-rc.0/preload-exists (gopogh)	n/a
Docker_Linux_crio_arm64	TestAddons/parallel/Ingress (gopogh)	n/a
Docker_Linux_crio_arm64	TestAddons/parallel/Olm (gopogh)	n/a
Docker_Linux_crio_arm64	TestAddons/parallel/Registry (gopogh)	n/a
Docker_Linux_crio_arm64	TestNetworkPlugins/group/calico/Start (gopogh)	n/a
Docker_Linux_crio_arm64	TestNetworkPlugins/group/cilium/Start (gopogh)	n/a
Docker_macOS	TestDebPackageInstall/install_amd64_debian (gopogh)	10/kvm2-driver (chart)
Docker_macOS	TestDebPackageInstall/install_amd64_debian (gopogh)	9/kvm2-driver (chart)
Docker_macOS	TestDebPackageInstall/install_amd64_debian (gopogh)	latest/kvm2-driver (chart)
Docker_macOS	TestDebPackageInstall/install_amd64_debian (gopogh)	sid/kvm2-driver (chart)
Docker_macOS	TestDebPackageInstall/install_amd64_ubuntu (gopogh)	18.04/kvm2-driver (chart)
Docker_macOS	TestDebPackageInstall/install_amd64_ubuntu (gopogh)	20.04/kvm2-driver (chart)
Docker_macOS	TestDebPackageInstall/install_amd64_ubuntu (gopogh)	20.10/kvm2-driver (chart)
Docker_macOS	TestDebPackageInstall/install_amd64_ubuntu (gopogh)	latest/kvm2-driver (chart)
Docker_macOS	TestDownloadOnly/v1.22.1/json-events (gopogh)	n/a
Docker_macOS	TestDownloadOnly/v1.22.1/kubectl (gopogh)	n/a
Docker_macOS	TestDownloadOnly/v1.22.1/preload-exists (gopogh)	n/a
Docker_macOS	TestDownloadOnly/v1.22.2-rc.0/json-events (gopogh)	n/a
Docker_macOS	TestDownloadOnly/v1.22.2-rc.0/kubectl (gopogh)	n/a
Docker_macOS	TestDownloadOnly/v1.22.2-rc.0/preload-exists (gopogh)	n/a
Docker_macOS	TestFunctional/parallel/BuildImage (gopogh)	n/a
Docker_macOS	TestFunctional/parallel/LoadImage (gopogh)	n/a
Docker_macOS	TestFunctional/parallel/LoadImageFromFile (gopogh)	n/a
Docker_macOS	TestFunctional/parallel/RemoveImage (gopogh)	n/a
Docker_macOS	TestFunctional/parallel/SaveImage (gopogh)	n/a
Docker_macOS	TestFunctional/parallel/SaveImageToFile (gopogh)	n/a
Docker_macOS	TestFunctional/parallel/TunnelCmd/serial/AccessThroughDNS (gopogh)	n/a
More tests...	Continued...

Too many tests failed - See test logs for more details.

To see the flake rates of all tests by environment, click here.

k8s-triage-robot · 2022-02-16T03:01:04Z

The Kubernetes project currently lacks enough contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Mark this issue or PR as fresh with /remove-lifecycle stale
Mark this issue or PR as rotten with /lifecycle rotten
Close this issue or PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

k8s-triage-robot · 2022-03-18T03:42:39Z

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Mark this issue or PR as fresh with /remove-lifecycle rotten
Close this issue or PR with /close
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

k8s-triage-robot · 2022-04-17T03:59:54Z

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied
After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Reopen this issue or PR with /reopen
Mark this issue or PR as fresh with /remove-lifecycle rotten
Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

k8s-ci-robot · 2022-04-17T04:00:10Z

@k8s-triage-robot: Closed this PR.

In response to this:

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues and PRs.

This bot triages issues and PRs according to the following rules:

After 90d of inactivity, lifecycle/stale is applied

After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied

After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

Reopen this issue or PR with /reopen

Mark this issue or PR as fresh with /remove-lifecycle rotten

Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

yayaha added 11 commits August 11, 2021 13:10

Use pool support in

ed309db

github.com/cheggaaa/pb/v3

Merge branch 'kubernetes:master' into luowei-dev

b325c5b

Use branched progressbar library

3d1cddd

Use branched progressbar library

d4448e2

Merge branch 'luowei-dev' of github.com:yayaha/minikube into luowei-dev

44dc64e

go mod tidy

b07c246

go mod tidy

749a0e6

Remove local minikube binary

b77b1be

Use chggaaa/pb/v3@v3.0.8 in the "require" section

2083073

Make image.go use DefaultProgressBar

e0618f9

Remember to log errors and clean up spaces

6e89511

k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Aug 12, 2021

k8s-ci-robot added cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Aug 12, 2021

k8s-ci-robot requested review from afbjorklund and spowelljr August 12, 2021 01:32

k8s-ci-robot assigned medyagh Aug 12, 2021

k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. and removed cncf-cla: no Indicates the PR's author has not signed the CNCF CLA. labels Aug 12, 2021

k8s-ci-robot added ok-to-test Indicates a non-member PR verified by an org member that is safe to test. and removed needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. labels Aug 12, 2021

yayaha changed the title ~~Use pooling support that's being added to cheggaaa/pb/v3 to fix download progress bar~~ WIP: Use pooling support that's being added to cheggaaa/pb/v3 to fix download progress bar Aug 13, 2021

k8s-ci-robot added the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Aug 13, 2021

Merge branch 'master' into luowei-dev

615df84

k8s-ci-robot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Nov 9, 2021

k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Feb 16, 2022

k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Mar 18, 2022

k8s-ci-robot closed this Apr 17, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

WIP: Use pooling support that's being added to cheggaaa/pb/v3 to fix download progress bar #12240

WIP: Use pooling support that's being added to cheggaaa/pb/v3 to fix download progress bar #12240

yayaha commented Aug 12, 2021

k8s-ci-robot commented Aug 12, 2021

k8s-ci-robot commented Aug 12, 2021

k8s-ci-robot commented Aug 12, 2021

minikube-bot commented Aug 12, 2021

yayaha commented Aug 12, 2021

medyagh commented Aug 12, 2021

minikube-pr-bot commented Aug 13, 2021

minikube-pr-bot commented Aug 13, 2021

yayaha commented Aug 13, 2021

yayaha commented Aug 19, 2021

medyagh commented Aug 23, 2021

k8s-ci-robot commented Aug 25, 2021

minikube-pr-bot commented Aug 25, 2021

k8s-ci-robot commented Aug 26, 2021

minikube-pr-bot commented Aug 26, 2021

k8s-ci-robot commented Nov 9, 2021

minikube-pr-bot commented Nov 18, 2021

minikube-pr-bot commented Nov 18, 2021

k8s-triage-robot commented Feb 16, 2022

k8s-triage-robot commented Mar 18, 2022

k8s-triage-robot commented Apr 17, 2022

k8s-ci-robot commented Apr 17, 2022

WIP: Use pooling support that's being added to cheggaaa/pb/v3 to fix download progress bar #12240

WIP: Use pooling support that's being added to cheggaaa/pb/v3 to fix download progress bar #12240

Conversation

yayaha commented Aug 12, 2021

k8s-ci-robot commented Aug 12, 2021

k8s-ci-robot commented Aug 12, 2021

k8s-ci-robot commented Aug 12, 2021

minikube-bot commented Aug 12, 2021

yayaha commented Aug 12, 2021

medyagh commented Aug 12, 2021

minikube-pr-bot commented Aug 13, 2021

minikube-pr-bot commented Aug 13, 2021

yayaha commented Aug 13, 2021

yayaha commented Aug 19, 2021

medyagh commented Aug 23, 2021

k8s-ci-robot commented Aug 25, 2021

minikube-pr-bot commented Aug 25, 2021

k8s-ci-robot commented Aug 26, 2021

minikube-pr-bot commented Aug 26, 2021

k8s-ci-robot commented Nov 9, 2021

minikube-pr-bot commented Nov 18, 2021

minikube-pr-bot commented Nov 18, 2021

k8s-triage-robot commented Feb 16, 2022

k8s-triage-robot commented Mar 18, 2022

k8s-triage-robot commented Apr 17, 2022

k8s-ci-robot commented Apr 17, 2022